Combine markers in the same location for better UX #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a state setter in `main.js` with the same name, but they do different things.
iandunn
changed the title
iandunn
force-pushed
the
map-duplicate-locations
branch
from
7611586 to
86a9e10
Compare
If we did nothing, then the markers would overlap and only 1 would be accessible. Spreading the markers out is a common solution, but then the user would have to click on each one to know which ones are relevant to them. In many cases, it's a recurring event, so they really only need to know about the next one. This way the user only has to click once, and they can see all of the info they need. See https://ux.stackexchange.com/a/112281/13828
These are more appropriate for refs than state because they need to persist across renders, but changing them shouldn't trigger a re-render.
iandunn
force-pushed
the
map-duplicate-locations
branch
from
86a9e10 to
f010e06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #431
If we did nothing, then the markers would overlap and only 1 would be accessible. Spreading the markers out is a common solution, but then the user would have to click on each one to know which ones are relevant to them. In many cases, it's a recurring event, so they really only need to know about the next one.
This way the user only has to click once, and they can see all of the info they need.
See https://ux.stackexchange.com/a/112281/13828