Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

People of WordPress & Community page lost focus styles #228

Closed
ryelle opened this issue Jan 22, 2022 · 1 comment
Closed

People of WordPress & Community page lost focus styles #228

ryelle opened this issue Jan 22, 2022 · 1 comment
Assignees
@ryelle
Labels
Accessibility Issues related to keyboard navigation, screen readers, etc [Type] Bug Something isn't working
Milestone
Initial Launch Fi...

Comments

@ryelle
Copy link
Contributor

ryelle commented Jan 22, 2022

This was caused by #207. Should just need focus-within added to the hover states.
@ryelle ryelle added [Type] Bug Something isn't working Accessibility Issues related to keyboard navigation, screen readers, etc labels Jan 22, 2022
@ryelle ryelle added this to the Initial Launch Final Stretch milestone Jan 22, 2022
@ryelle ryelle self-assigned this Jan 22, 2022
ryelle added a commit that referenced this issue Jan 22, 2022
@ryelle
People of WordPress: Accessibility fixes
c5e8ab3 
Use `focus-within` to add the hover effect & dotted focus indicator when the links inside are focused.
Hide title accessibly (so it's visible to screen readers), and only hide title when there is a featured image.

See #228
@ryelle
Copy link
Contributor Author

ryelle commented Jan 22, 2022

Fixed in c5e8ab3 & 10168dc

@ryelle ryelle closed this as completed Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryelle ryelle

Labels
Accessibility Issues related to keyboard navigation, screen readers, etc [Type] Bug Something isn't working
Projects
None yet
Milestone
Initial Launch Final Stretch
Development

No branches or pull requests
1 participant
@ryelle