Fix broken pagination links

[iandunn]

It looks like all the uses of pagination are broken.

• front-page/ template parts - "See all ..." links to /?query-page=2 instead of /page/2. That might be a bug with wp:query-pagination-next, or maybe we're using it wrong. See Restore "All Posts" header etc #55
• archive/category templates - links to pages have broken query-page param instead of page/n format
• archive/category templates - shown even when cat only has 1 post
• Look for those problems in other templates too, and fix any instances

[jeffikus]

@scruffian @matiasbenedetto is this related to any of the work we've been doing on pagination? Anything we can use from there to help here?

[scruffian]

No, this is unrelated

[ryelle]

It looks like if you use inherit on the main posts query, the pagination link on "See All Posts" should link to /page/2/ WordPress/gutenberg#32531 (comment)

<!-- wp:query {"query":{"perPage":5,"inherit":"true"},"tagName":"section","className":"front__latest-posts","align":"full"} -->

[tellyworth]

It looks like if you use inherit on the main posts query

The problem with this is that when you use inherit the query block seems to ignore other query parameters like perPage. I'm not sure if that's expected behaviour or a bug.

[ryelle]

That's a good question. It looks like the block query gets merged into the main query, but values in the main query will override the block values… I think that is intended. If you try this through the editor, hitting "Inherit query from template" turns off all the UI controls for taxonomies and per-page settings.

[tellyworth]

Thanks for digging that up @ryelle. I'm pretty sure the code in render_block_core_post_template() has a number of undesirable side effects that are going to cause problems for block themes. As well as the perPage thing noted above, this means you get inconsistent versions of query vars in filters. I think I'll have to write up some detailed test cases to clarify and figure out how to move forward.