Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start community category styles #199

Merged
merged 11 commits into from
Jan 18, 2022
Merged

Start community category styles #199

merged 11 commits into from
Jan 18, 2022

Conversation

MaggieCabrera
Copy link
Collaborator

Partially addresses #148

This adds some starting styles to the Community category page

Desktop:

Screenshot 2022-01-14 at 12-43-12 Community – wporg-news-2021

Mobile:

Screenshot 2022-01-14 at 12-43-20 Community – wporg-news-2021

@ryelle ryelle self-requested a review January 14, 2022 16:34
@ryelle
Copy link
Contributor

ryelle commented Jan 14, 2022

It looks like this template has specific hover/focus styles:
Screen Shot 2022-01-14 at 11 56 06 AM
Screen Shot 2022-01-14 at 11 56 17 AM

@MaggieCabrera
Copy link
Collaborator Author

It looks like this template has specific hover/focus styles:

Oh I missed those, thank you!

@ryelle ryelle self-requested a review January 17, 2022 17:33
@beafialho
Copy link
Collaborator

@MaggieCabrera it's looking good!

  • The black color on hover seems darker in the screenshot. Just wanted to make sure it's set to #1E1E1E as intended.

Captura de ecrã 2022-01-17, às 17 24 48

  • Could you please make sure that the post titles with images have the same spacing as the ones without images? Those are sitting a little bit lower than the others:

Captura de ecrã 2022-01-17, às 17 28 23

  • For tablet sizes, the titles overlap and aren't readable. Is there any chance to improve their responsiveness or is this a Gutenberg issue?
Gravacao.do.ecra.2022-01-17.as.17.30.55.mov

Copy link
Contributor

@ryelle ryelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! I have a few small changes requested, and could you run the linter & fix the issues?

yarn workspace wporg-news-2021-theme lint:css --fix

MaggieCabrera and others added 2 commits January 18, 2022 10:16
…gories.scss

Co-authored-by: Kelly Dwan <ryelle@users.noreply.github.com>
@MaggieCabrera
Copy link
Collaborator Author

@beafialho is it ok if we jump from 4 per column to 3 or 2 when we go to tablet size to avoid the issue you highlighted?

@beafialho
Copy link
Collaborator

@MaggieCabrera yes, we can use 3 or 2 columns

@MaggieCabrera
Copy link
Collaborator Author

ok, this is ready for another review, I fixed all the mentioned issues, and changed the grid to drop to 3, then 2 then 1 column while we lower the viewport width

@beafialho
Copy link
Collaborator

Looks perfect @MaggieCabrera!

Do you have any idea why this post has the off white background?

Captura de ecrã 2022-01-18, às 09 57 38

@MaggieCabrera
Copy link
Collaborator Author

Looks perfect @MaggieCabrera!

Do you have any idea why this post has the off white background?

It's marked with the class .has-post-thumbnail so it should be showing an image instead of the blue background, I'm not sure if there's a problem with the imported content or what's going on there. I could add the blue background always by default so this is not a problem

@MaggieCabrera
Copy link
Collaborator Author

It's marked with the class .has-post-thumbnail so it should be showing an image instead of the blue background, I'm not sure if there's a problem with the imported content or what's going on there. I could add the blue background always by default so this is not a problem

Nevermind that, I did that but the text only appears on hover, as do all the rest of the posts with an image. I think it's best to just make sure that the post has a thumbnail correctly in this case

@ryelle ryelle self-requested a review January 18, 2022 15:39
@ryelle
Copy link
Contributor

ryelle commented Jan 18, 2022

I have the same post missing a featured image, I think there must've been an issue in the export. If I remove the (broken) featured image, it works as expected.

Copy link
Contributor

@ryelle ryelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻
Thanks for all your work!

@ryelle ryelle merged commit 345efcd into trunk Jan 18, 2022
@ryelle ryelle deleted the try-community-cateogry-styles branch January 18, 2022 16:04
@ryelle ryelle linked an issue Jan 19, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

community - final markup and css
3 participants