-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start community category styles #199
Conversation
Oh I missed those, thank you! |
source/wp-content/themes/wporg-news-2021/sass/components/_categories.scss
Outdated
Show resolved
Hide resolved
@MaggieCabrera it's looking good!
Gravacao.do.ecra.2022-01-17.as.17.30.55.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good! I have a few small changes requested, and could you run the linter & fix the issues?
yarn workspace wporg-news-2021-theme lint:css --fix
source/wp-content/themes/wporg-news-2021/block-template-parts/content-category-community.html
Outdated
Show resolved
Hide resolved
source/wp-content/themes/wporg-news-2021/sass/components/_categories.scss
Outdated
Show resolved
Hide resolved
source/wp-content/themes/wporg-news-2021/sass/components/_categories.scss
Outdated
Show resolved
Hide resolved
…gories.scss Co-authored-by: Kelly Dwan <ryelle@users.noreply.github.com>
@beafialho is it ok if we jump from 4 per column to 3 or 2 when we go to tablet size to avoid the issue you highlighted? |
@MaggieCabrera yes, we can use 3 or 2 columns |
ok, this is ready for another review, I fixed all the mentioned issues, and changed the grid to drop to 3, then 2 then 1 column while we lower the viewport width |
Looks perfect @MaggieCabrera! Do you have any idea why this post has the off white background? |
It's marked with the class |
Nevermind that, I did that but the text only appears on hover, as do all the rest of the posts with an image. I think it's best to just make sure that the post has a thumbnail correctly in this case |
I have the same post missing a featured image, I think there must've been an issue in the export. If I remove the (broken) featured image, it works as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Thanks for all your work!
Partially addresses #148
This adds some starting styles to the Community category page
Desktop:
Mobile: