Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single post view #21

Merged
merged 11 commits into from
Aug 27, 2021
Merged

Single post view #21

merged 11 commits into from
Aug 27, 2021

Conversation

coreymckrill
Copy link
Contributor

@coreymckrill coreymckrill commented Aug 24, 2021

Adds block templates and template parts, tweaks the theme.json file, and adds some rules to the stylesheet to create the single post view as depicted in the mockup in #17.

This includes a responsive layout for the post title/meta area and the main post content column. The post content also accommodates wide and full alignment on individual blocks.

This doesn't include the global header or footer (see #6). It also doesn't include the social sharing links or like button shown in the mockup, because those elements are not yet available as site blocks. (There's an issue for the Like button, couldn't find one for social sharing icons.)

The mockup doesn't include a comment section, and it appears that the News site does not currently have comments enabled, so that has also been omitted.

Fixes #17

To test

  1. The post used in the mockup is also included in the test content that gets added to the local dev environment for this repo, so you can easily compare the two.
  2. Try changing the alignment of some blocks in the post to Wide and Full to see how those work.
  3. Try changing the viewport size to find the responsive breakpoints.

@coreymckrill coreymckrill added this to the Initial Launch milestone Aug 24, 2021
@coreymckrill coreymckrill self-assigned this Aug 24, 2021
@coreymckrill coreymckrill marked this pull request as ready for review August 25, 2021 20:12
@coreymckrill coreymckrill requested a review from iandunn August 25, 2021 20:15
Copy link
Member

@iandunn iandunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Grid and SCRIPT_DEBUG comments seem important to discuss more before merging, but I don't feel strongly about the others.

Copy link
Member

@iandunn iandunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments would be great, but not a blocker. Thanks!

@coreymckrill coreymckrill merged commit 7241d17 into trunk Aug 27, 2021
iandunn added a commit that referenced this pull request Aug 27, 2021
"ponyfill" is a confusing deviation from the convention.

See #21 (comment)
@iandunn iandunn deleted the fix/17/single-post-template branch November 5, 2021 20:25
@iandunn iandunn removed this from the Initial Launch: Functionality milestone Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement design for single posts
2 participants