-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single post view #21
Single post view #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Grid and SCRIPT_DEBUG
comments seem important to discuss more before merging, but I don't feel strongly about the others.
source/wp-content/themes/wporg-news-2021/block-template-parts/content-single.html
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comments would be great, but not a blocker. Thanks!
"ponyfill" is a confusing deviation from the convention. See #21 (comment)
Adds block templates and template parts, tweaks the theme.json file, and adds some rules to the stylesheet to create the single post view as depicted in the mockup in #17.
This includes a responsive layout for the post title/meta area and the main post content column. The post content also accommodates wide and full alignment on individual blocks.
This doesn't include the global header or footer (see #6). It also doesn't include the social sharing links or like button shown in the mockup, because those elements are not yet available as site blocks. (There's an issue for the Like button, couldn't find one for social sharing icons.)
The mockup doesn't include a comment section, and it appears that the News site does not currently have comments enabled, so that has also been omitted.
Fixes #17
To test