Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles: Update external link icon #100

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Conversation

ryelle
Copy link
Contributor

@ryelle ryelle commented Aug 30, 2023

The "external link" icon should be the up-right arrow [↗︎]. It is already used this way in the global header menu. This icon is also used on the site as a decorative element, in those spaces it's used inline as a real character. This does not change anything there.

When the external-link class is used on a link element or container (eg, paragraph), it will add the icon as a background, so that it is not underlined (and to prevent screen readers from reading it, see #94).

Fixes #64 — We've standardized on the single arrow, for both decorative and external links.

Screenshots

Before After
Screenshot 2023-08-30 at 4 10 40 PM Screenshot 2023-08-30 at 4 10 05 PM

How to test the changes in this Pull Request:

Try using this branch with the showcase site:

  1. View a single site page
  2. Below the title, the URL should have the new arrow icon

Or without a separate site:

  1. Create a new post/page, add a paragraph
  2. Add the external-link class to the paragraph under Advanced
  3. Add a link in the paragraph content, not pointing to wordpress.org.
  4. View on the front end
  5. It should have the new arrow icon

@ryelle ryelle added the [Component] Theme Templates, patterns, CSS label Aug 30, 2023
@ryelle ryelle self-assigned this Aug 30, 2023
@ryelle ryelle merged commit 56267d7 into trunk Aug 30, 2023
@ryelle ryelle deleted the update/external-link-arrow branch August 30, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Theme Templates, patterns, CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

↗︎ emoji is very similar to "external link" and "opens in new tab" icons
1 participant