Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "external link" icon should be the up-right arrow [↗︎]. It is already used this way in the global header menu. This icon is also used on the site as a decorative element, in those spaces it's used inline as a real character. This does not change anything there.
When the
external-link
class is used on a link element or container (eg, paragraph), it will add the icon as a background, so that it is not underlined (and to prevent screen readers from reading it, see #94).Fixes #64 — We've standardized on the single arrow, for both decorative and external links.
Screenshots
How to test the changes in this Pull Request:
Try using this branch with the showcase site:
Or without a separate site:
external-link
class to the paragraph under Advanced