Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebAuthn: Link to wp-admin until custom UI is built. #141

Closed
wants to merge 1 commit into from

Conversation

iandunn
Copy link
Member

@iandunn iandunn commented Apr 28, 2023

See #114
Based on #95

This adds a stub for the custom WebAuthn UI, so that users will be aware it is an option. It's behind a feature flag until all the other PRs associated with #114 are done. At that point, it can be enabled for everyone.

This may need some design/copy tweaks, but it's temporary, so IMO it's best to not spend too much time on it.

Screenshot 2023-04-28 at 12 43 42 PM

Screenshot 2023-04-28 at 12 43 57 PM

@iandunn iandunn self-assigned this Apr 28, 2023
@iandunn iandunn added this to the MVP milestone Apr 28, 2023
@iandunn iandunn requested review from renintw and jasmussen April 28, 2023 19:45
This was referenced Apr 28, 2023
@jasmussen
Copy link
Collaborator

CC: @fcoveram as it may relate to some of the "password strength" mockups you did.

@iandunn
Copy link
Member Author

iandunn commented May 1, 2023

Did you mean to leave that comment on #131 ? If not, I'm confused about how it relates to this PR. Do you mind clarifying?

@jasmussen
Copy link
Collaborator

Sorry, I did not mean to be intentionally obtuse. I mean that the iconography (check vs. X), the use of color and notices, and the indicators for whether something is complete or incomplete (in this case, steps in the stepper) could/should arguably share DNA with the same iconography and indication we use for password strength, if not now then at least at some point in the future.

Here are a couple of quick snaps from Francisco's work, which relies more on the high contrast which gray icons and text can give, compared to stoplight colors:

Screenshot 2023-05-01 at 18 13 36

Screenshot 2023-05-01 at 18 13 57

Screenshot 2023-05-01 at 18 14 02

@iandunn
Copy link
Member Author

iandunn commented May 1, 2023

Ah, that makes sense, thanks! Do you mind if I create a new issue for that, since it applies to all of the UI, rather than something specific to this PR?

@StevenDufresne
Copy link
Contributor

Thanks for the ticket. I'm thinking we can omit this from the MVP launch in favor of releasing faster and managing expectations. As soon as we release this view, we'll be "on the clock" to switch it out. Instead, maybe we could mention the /wp-admin path for WebAuthn in the beta/alpha launch post and iterate with more data. Thoughts?

@fcoveram
Copy link

fcoveram commented May 2, 2023

@StevenDufresne I'm fine with delaying the style tweak and mentioning it for the upcoming changes

Thanks @iandunn. Please ping me in the ticket you will open to share a design idea.

@StevenDufresne
Copy link
Contributor

@StevenDufresne I'm fine with delaying the style tweak and mentioning it for the upcoming changes

Thanks @iandunn. Please ping me in the ticket you will open to share a design idea.

Just for clarity, I was talking about the list item "Two Factor Security Key" in the description. I don't think that is necessary for launch.

The second thread revolves around style treatment and @iandunn's has offered to open a new ticket regarding that. I am also in agreement that we could also iterate on that. 👍

@iandunn
Copy link
Member Author

iandunn commented May 2, 2023

Thanks! I created #145 for the that @fcoveram. The changes don't necessarily have to be delayed, it's just a lot easier to manage when there are separate issues for unrelated things. In some cases that can actually make it faster, because someone else on the team can pick it up and work on it in parallel.

Instead, maybe we could mention the /wp-admin path for WebAuthn in the beta/alpha launch post and iterate with more data

That sounds good, I'll go ahead and close this 👍🏻

@iandunn iandunn closed this May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants