Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): Remove uuid and update unique id generation #1408

Merged
merged 12 commits into from
Jan 7, 2022
Merged

feat(common): Remove uuid and update unique id generation #1408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c120a03
chore: Remove uuid and update unique id generation
NicholasBoll Jan 4, 2022
b983bfc
Add tests, documentation, and fix type errors
NicholasBoll Jan 5, 2022
81e7828
Remove a .only
NicholasBoll Jan 5, 2022
9041420
Remove unwanted change
NicholasBoll Jan 5, 2022
e976ed0
Fix mistakes
NicholasBoll Jan 6, 2022
dbc9535
Add blurb in our testing doc about stabile snapshot tests
NicholasBoll Jan 7, 2022
b581fdc
Remove request and update jest, jest-junit, and node-sass to remove u…
NicholasBoll Jan 7, 2022
6e38744
Fix resolution of node-sass
NicholasBoll Jan 7, 2022
01d45d9
Upgrade rollup to remove multiple @types/node
NicholasBoll Jan 7, 2022
8be6b18
Remove extra @types/node
NicholasBoll Jan 7, 2022
3655f6a
Remove redundant types
NicholasBoll Jan 7, 2022
3923ae4
Removed the babel message
NicholasBoll Jan 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion babel.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@ module.exports = {
env: {
test: {
presets: ['@babel/preset-env', '@babel/preset-typescript', '@babel/preset-react'],
plugins: ['emotion', '@babel/proposal-class-properties', '@babel/plugin-transform-runtime'],
plugins: [
'emotion',
['@babel/proposal-class-properties', {loose: true}], // https://github.com/storybookjs/storybook/issues/14805 and https://github.com/storybookjs/storybook/issues/14805#issuecomment-889504884
'@babel/plugin-transform-runtime',
],
},
},
};
6 changes: 3 additions & 3 deletions cypress/integration/Combobox.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ describe('Combobox', () => {
});

it('should not show menu', () => {
cy.findByRole('listbox').should('not.be.visible');
cy.findByRole('listbox').should('not.exist');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these were due to a breaking change in Cypress v6.

This "fix" did find legitimate issues with our tests, but I feel like we've lost some semantics. I want to know if the element is no longer accessible to the user. Whether it is still in the DOM or just hidden is an implementation detail. Perhaps I'll make an be.inaccessible assertion that does this.

});

it('should show the clear button', () => {
Expand Down Expand Up @@ -154,7 +154,7 @@ describe('Combobox', () => {
});

it('should close the listbox', () => {
cy.findByRole('listbox').should('not.be.visible');
cy.findByRole('listbox').should('not.exist');
});

context('when the use hits the "a" key', () => {
Expand Down Expand Up @@ -213,7 +213,7 @@ describe('Combobox', () => {
});

it('should close the listbox', () => {
cy.findByRole('listbox').should('not.be.visible');
cy.findByRole('listbox').should('not.exist');
});

it('should keep focus on combobox', () => {
Expand Down
24 changes: 12 additions & 12 deletions cypress/integration/Modal.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ describe('Modal', () => {
});

it('should close the modal', () => {
cy.findByRole('dialog', {name: 'Delete Item'}).should('not.be.visible');
cy.findByRole('dialog', {name: 'Delete Item'}).should('not.exist');
});

it('should transfer focus back to the target button', () => {
Expand All @@ -143,7 +143,7 @@ describe('Modal', () => {
});

it('should close the modal', () => {
cy.findByRole('dialog', {name: 'Delete Item'}).should('not.be.visible');
cy.findByRole('dialog', {name: 'Delete Item'}).should('not.exist');
});
});

Expand All @@ -153,7 +153,7 @@ describe('Modal', () => {
});

it('should close the modal', () => {
cy.findByRole('dialog', {name: 'Delete Item'}).should('not.be.visible');
cy.findByRole('dialog', {name: 'Delete Item'}).should('not.exist');
});
});
});
Expand Down Expand Up @@ -189,11 +189,11 @@ describe('Modal', () => {
});

it(`should close the 'Cancel' tooltip`, () => {
cy.findByRole('tooltip', {name: 'Not so sure'}).should('not.be.visible');
cy.findByRole('tooltip', {name: 'Not so sure'}).should('not.exist');
});

it(`should close the modal`, () => {
cy.findByRole('dialog', {name: 'Open Modal'}).should('not.be.visible');
cy.findByRole('dialog', {name: 'Open Modal'}).should('not.exist');
});
});
});
Expand Down Expand Up @@ -225,11 +225,11 @@ describe('Modal', () => {
it(`should close the 'OK' tooltip`, () => {
cy.findByRole('tooltip', {
name: 'Really, Really, Really, Really, Really sure',
}).should('not.be.visible');
}).should('not.exist');
});

it(`should close the 'Hidable Popup' popup`, () => {
cy.findByRole('dialog', {name: 'Hidable Popup'}).should('not.be.visible');
cy.findByRole('dialog', {name: 'Hidable Popup'}).should('not.exist');
});

it(`should keep the modal open`, () => {
Expand Down Expand Up @@ -268,13 +268,13 @@ describe('Modal', () => {
});

it(`should close the modal`, () => {
cy.findByRole('dialog', {name: 'Non-hidable'}).should('not.be.visible');
cy.findByRole('dialog', {name: 'Non-hidable'}).should('not.exist');
});

it(`should close the 'OK' tooltip`, () => {
cy.findByRole('tooltip', {
name: 'Really, Really, Really, Really, Really sure',
}).should('not.be.visible');
}).should('not.exist');
});
});
});
Expand Down Expand Up @@ -518,7 +518,7 @@ describe('Modal', () => {
});

it('should close the modal', () => {
cy.findByRole('dialog', {name: 'Delete Item'}).should('not.be.visible');
cy.findByRole('dialog', {name: 'Delete Item'}).should('not.exist');
});
});

Expand All @@ -528,7 +528,7 @@ describe('Modal', () => {
});

it('should close the modal', () => {
cy.findByRole('dialog', {name: 'Delete Item'}).should('not.be.visible');
cy.findByRole('dialog', {name: 'Delete Item'}).should('not.exist');
});
});
});
Expand Down Expand Up @@ -633,7 +633,7 @@ describe('Modal', () => {
});

it('should hide the modal', () => {
cy.findByRole('dialog', {name: 'Modal'}).should('not.be.visible');
cy.findByRole('dialog', {name: 'Modal'}).should('not.exist');
});

it('should move focus back to the "Open" button', () => {
Expand Down
12 changes: 6 additions & 6 deletions cypress/integration/Popup.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ describe('Popup', () => {
});

it('should hide the popup', () => {
cy.findByRole('dialog').should('not.visible');
cy.findByRole('dialog').should('not.exist');
});
});

Expand All @@ -55,7 +55,7 @@ describe('Popup', () => {
});

it('should hide the popup', () => {
cy.findByRole('dialog').should('not.visible');
cy.findByRole('dialog').should('not.exist');
});
});

Expand All @@ -65,7 +65,7 @@ describe('Popup', () => {
});

it('should close the popup', () => {
cy.findByRole('dialog').should('not.visible');
cy.findByRole('dialog').should('not.exist');
});
});
});
Expand Down Expand Up @@ -315,11 +315,11 @@ describe('Popup', () => {
it('should close the tooltip', () => {
cy.findByRole('tooltip', {
name: 'Really long tooltip showing how popup stacks overlap 2',
}).should('not.be.visible');
}).should('not.exist');
});

it('should close the "Really Delete Item" popup', () => {
cy.findByRole('dialog', {name: 'Really Delete Item'}).should('be.not.visible');
cy.findByRole('dialog', {name: 'Really Delete Item'}).should('not.exist');
});

it('should NOT close the "Delete Item" popup', () => {
Expand Down Expand Up @@ -351,7 +351,7 @@ describe('Popup', () => {
});

it('should hide the popup', () => {
cy.findByRole('dialog', {name: 'Popup'}).should('not.be.visible');
cy.findByRole('dialog', {name: 'Popup'}).should('not.exist');
});

it('should move focus back to the "Open" button', () => {
Expand Down
6 changes: 3 additions & 3 deletions cypress/integration/SelectPreview.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ describe('Select', () => {
it('should not be visible', () => {
cy.findByLabelText('Label')
.pipe(h.selectPreview.getMenu)
.should('not.be.visible');
.should('not.exist');
});
});

Expand Down Expand Up @@ -242,7 +242,7 @@ describe('Select', () => {
it('should not be visible', () => {
cy.findByLabelText('Label')
.pipe(h.selectPreview.getMenu)
.should('not.be.visible');
.should('not.exist');
});
});

Expand Down Expand Up @@ -664,7 +664,7 @@ describe('Select', () => {
// it('should not be visible', () => {
// cy.findByLabelText('Label')
// .pipe(h.selectPreview.getMenu)
// .should('not.be.visible');
// .should('not.exist');
// });
// });
// });
Expand Down
22 changes: 11 additions & 11 deletions cypress/integration/Tooltip.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ describe('Tooltip', () => {
});

it('should close the tooltip', () => {
cy.findByRole('tooltip').should('not.be.visible');
cy.findByRole('tooltip').should('not.exist');
});
});

Expand All @@ -62,7 +62,7 @@ describe('Tooltip', () => {
});

it('should not close the tooltip', () => {
cy.findByRole('tooltip').should('not.be.visible');
cy.findByRole('tooltip').should('not.exist');
});
});
});
Expand All @@ -82,7 +82,7 @@ describe('Tooltip', () => {
});

it('should close the tooltip', () => {
cy.findByRole('tooltip').should('not.be.visible');
cy.findByRole('tooltip').should('not.exist');
});
});

Expand All @@ -104,7 +104,7 @@ describe('Tooltip', () => {
});

it('should close immediately, not waiting for blur or intent', () => {
cy.findByRole('tooltip', {timeout: 0}).should('not.be.visible');
cy.findByRole('tooltip', {timeout: 0}).should('not.exist');
});
});
});
Expand Down Expand Up @@ -155,14 +155,14 @@ describe('Tooltip', () => {
});

it('the span element should not have an aria-describedby attribute', () => {
cy.get('button').should('not.have.attr', 'aria-describedby');
cy.get('span').should('not.have.attr', 'aria-describedby');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was caught by the change in Cypress v6. Before, not.have.attr would pass even if cy.get('button') never actually matched anything. This was a typo from long ago that Cypress was perfectly happy to incorrectly pass.

});

it('the span element should not have an aria-label attribute', () => {
cy.get('button').should('not.have.attr', 'aria-describedby');
cy.get('span').should('not.have.attr', 'aria-describedby');
});

context('when the "Delete" button is hovered', () => {
context('when the "Some Text" text is hovered', () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a copy/paste error. The tooltip isn't from a delete button, but a span with some text.

beforeEach(() => {
cy.get('span').trigger('mouseover');
});
Expand All @@ -176,11 +176,11 @@ describe('Tooltip', () => {
});

it('the span element should not have an aria-describedby attribute', () => {
cy.get('button').should('not.have.attr', 'aria-describedby');
cy.get('span').should('not.have.attr', 'aria-describedby');
});

it('the span element should not have an aria-label attribute', () => {
cy.get('button').should('not.have.attr', 'aria-describedby');
cy.get('span').should('not.have.attr', 'aria-describedby');
});
});
});
Expand All @@ -204,7 +204,7 @@ describe('Tooltip', () => {
});

it('should not show the tooltip', () => {
cy.findByRole('tooltip').should('not.be.visible');
cy.findByRole('tooltip').should('not.exist');
});
});

Expand Down Expand Up @@ -244,7 +244,7 @@ describe('Tooltip', () => {
});

it('should not show the tooltip', () => {
cy.findByRole('tooltip').should('not.be.visible');
cy.findByRole('tooltip').should('not.exist');
});
});

Expand Down
Loading