Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cypress Flaky fixes #3034

Open
wants to merge 78 commits into
base: master
Choose a base branch
from

Conversation

josh-bagwell
Copy link
Contributor

Summary

Fixes: #2900

This is adding fixes for the Cypress flaky specs that were caused from the Webpack Upgrade

Release Category

Infrastructure


Where Should the Reviewer Start?

/cypress/component

Copy link

cypress bot commented Nov 5, 2024

Workday/canvas-kit    Run #8098

Run Properties:  status check passed Passed #8098  •  git commit 39f5bbde4b ℹ️: Merge 5d8a646fa188bc8bacd398981d858dfd85882026 into 9a6f57a9daed9618b7de81ff67ec...
Project Workday/canvas-kit
Branch Review fix-flaky-24-11
Run status status check passed Passed #8098
Run duration 02m 50s
Commit git commit 39f5bbde4b ℹ️: Merge 5d8a646fa188bc8bacd398981d858dfd85882026 into 9a6f57a9daed9618b7de81ff67ec...
Committer Josh
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 21
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 923
View all changes introduced in this branch ↗︎
UI Coverage  21.16%
  Untested elements 1533  
  Tested elements 409  
Accessibility  99.14%
  Failed rules  6 critical   5 serious   0 moderate   2 minor
  Failed elements 162  

Comment on lines +30 to +31
<span>Current Container Width: {containerWidth}</span>
<span>Overflow visibility: {model.menu.state.visibility}</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we don't need this anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind keeping this around.

It at least gives us the visual

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cypress Flaky tests need to be updated
2 participants