chore: Release v4.0.0-beta.1 #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
lychyi
approved these changes
Apr 14, 2020
Comment on lines
+183
to
+184
| Tooltip now uses React Portals and has been completely updated to make attaching tooltips much | ||
| easier. |
There was a problem hiding this comment.
Suggested change
| Tooltip now uses React Portals and has been completely updated to make attaching tooltips much | |
| easier. | |
| Tooltip now uses our Popper component and has been completely updated to make attaching tooltips | |
| much easier. |
There was a problem hiding this comment.
Should we add an example of the new usage?
Like:
<Tooltip title="Add">
<IconButton variant={IconButton.Variant.Circle} icon={xIcon} aria-label="Add" />
</Tooltip>There was a problem hiding this comment.
Planning to convert this migration guide into a 4.0 guide before the final release with notes about all the new features. Definitely want to include this, but was thinking it belonged there 👍
NicholasBoll
approved these changes
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
yarn bump prerelease --preid betaInfrastructure
Components