test(avatar): Add snapshot tests for Avatar and AvatarButton #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
| // @ts-ignore: Cannot find module error | ||
| import testAvatar from './test-avatar.png'; | ||
| // eslint-disable-next-line no-empty-function | ||
| const noop = () => {}; |
There was a problem hiding this comment.
this could be somewhere in test utils folder?
| component: Avatar, | ||
| parameters: { | ||
| chromatic: { | ||
| delay: 300, // Ensure we capture the image after loading and transition |
There was a problem hiding this comment.
NB: I could see this being a utils as well since we have a few components that have transitions
There was a problem hiding this comment.
Most of the time we turn off transitions w/ transformOrigin={null} rather than using a delay though. This is the only place we use a chromatic delay atm so going to leave as is for now
mannycarrera4
approved these changes
Jun 3, 2020
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #683
These tests are based on the ones added to
prerelease/v4in #676