Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(drawer): Add stories and snapshots for drawer #727

Merged
merged 5 commits into from
Jun 11, 2020
Merged

test(drawer): Add stories and snapshots for drawer #727

merged 5 commits into from
Jun 11, 2020

Conversation

mannycarrera4
Copy link
Contributor

Summary

Partially fixes: #683
Add snapshots for drawer component

@@ -8,7 +8,7 @@ export interface DrawerHeaderProps extends React.HTMLAttributes<HTMLDivElement>
/**
* The text of the DrawerHeader. This text will also be applied as the `title` attribute of the header element.
*/
headerText?: string;
title?: string;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was the "bug" that i found

@cypress
Copy link

cypress bot commented Jun 10, 2020



Test summary

317 0 0 0


Run details

Project canvas-kit
Status Passed
Commit d8f540b ℹ️
Started Jun 10, 2020 10:56 PM
Ended Jun 10, 2020 10:59 PM
Duration 03:20 💡
OS Linux Ubuntu Linux - 18.04
Browser Electron 80

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@NicholasBoll NicholasBoll added the approved Code has been reviewed and approved (ship it) label Jun 10, 2020
@mannycarrera4 mannycarrera4 merged commit bf56f92 into Workday:master Jun 11, 2020
@lychyi lychyi mentioned this pull request Jun 17, 2020
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Code has been reviewed and approved (ship it)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve visual testing coverage
2 participants