Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widen Analyzer #170

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Widen Analyzer #170

merged 2 commits into from
Sep 5, 2023

Conversation

robbecker-wf
Copy link
Member

Raises the allowed analyzer version to allow the 4x versions.

@@ -16,7 +16,7 @@ jobs:
strategy:
fail-fast: false
matrix:
sdk: [ 2.18.7, stable, beta ]
sdk: [ 2.18.7 ]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note Dart 3+ was removed because everything 2.19 and greater fail to build with an older analyzer version than 5.
Underlying root cause dart-lang/sdk#51128
Newer Dart versions are added back in the PR that updates to analyzer 5 here https://github.com/davidmarne/built_redux/pull/171/files#diff-0530c3bf28665689d37061f6d19aade372700afec3ae45decc3f2edbd64e344dR19

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robbecker-wf robbecker-wf marked this pull request as ready for review September 5, 2023 13:43
@davidmarne davidmarne merged commit 5059fde into Workiva:master Sep 5, 2023
1 check passed
@robbecker-wf robbecker-wf deleted the widen_analyzer branch September 5, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants