Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollout Analyzer 5 #69

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Rollout Analyzer 5 #69

merged 3 commits into from
Sep 22, 2023

Conversation

sourcegraph-wk
Copy link

Rollout Analyzer 5

This batch will raise the minimum of workiva_dependency_constrainer
to one that requires analyzer 5, thus ensuring that a repo resolves
to analyzer 5. It also raises the minimums of other packages that
are needed, like built_value.

Things that may need fixing manually

  1. Probably the most common thing is that built_value generated code
    will need to be regenerated. There should be no breaking changes in
    this new generated code. Some repos have a make target called gen,
    gen-built or similar, or just run a full dart run build_runner build

  2. The temporary fix for Dart coverage needs to be removed. The fix
    is to simply remove lines like these below from Github Actions. This PR
    will have raised the minimum of the test package to 1.21.1 which is
    the first version needed that removes the need to backpatched test
    versions.

  - uses: Workiva/gha-dart/temp-coverage-setup@v0.2.28
    with:
      test-package-version: 1.20.1
  1. As part of moving to analyzer 5, the sort_pub_dependencies lint
    seems to act as a warning now, causing analyze to fail CI.
    To fix: either sort the dependencies in alphabetical order or
    alter the analysis_options.yaml to lower the severity to a hint

For more info, reach out to #support-frontend-dx on Slack.

Created by Sourcegraph batch change Workiva/analyzer_5.

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@robbecker-wf robbecker-wf added Hold Hold merges and removed Hold Hold merges labels Sep 21, 2023
@robbecker-wf robbecker-wf reopened this Sep 22, 2023
@robbecker-wf robbecker-wf marked this pull request as ready for review September 22, 2023 20:56
@robbecker-wf
Copy link
Member

QA+1 CI passes @Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole3-wf rmconsole3-wf merged commit cce8a6c into master Sep 22, 2023
8 checks passed
@rmconsole3-wf rmconsole3-wf deleted the batch/fedx/analyzer_5 branch September 22, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants