Skip to content

Commit

Permalink
Remove browser_detect dependency
Browse files Browse the repository at this point in the history
+ It is abandonware.  Use Workiva’s platform_detect instead.
  • Loading branch information
aaronlademann-wf committed Jun 13, 2017
1 parent 9c17956 commit 43aa8b1
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
3 changes: 1 addition & 2 deletions pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,9 @@ dependencies:
source_span: "^1.2.0"
transformer_utils: "^0.1.1"
w_flux: "^2.5.0"
platform_detect: "^1.1.1"
platform_detect: "^1.3.2"
quiver: ">=0.21.4 <0.25.0"
dev_dependencies:
browser_detect: "^1.0.4"
matcher: ">=0.11.0 <0.13.0"
coverage: "^0.7.2"
dart_dev: "^1.0.5"
Expand Down
4 changes: 2 additions & 2 deletions test/test_util/dom_util.dart
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import 'dart:async';
import 'dart:html';
import 'dart:js';

import 'package:browser_detect/browser_detect.dart';
import 'package:platform_detect/platform_detect.dart';

/// Dispatches a `transitionend` event when the CSS transition of the [element]
/// is complete. Returns a [Future] that completes after the event has been dispatched.
Expand All @@ -43,7 +43,7 @@ Future triggerTransitionEnd(Element element) {
}

// Need to use webkitTransitionEnd in Edge. See https://github.com/dart-lang/sdk/issues/26972
var eventName = (browser.isIe && browser.version > '11') ? 'webkitTransitionEnd' : 'transitionend';
var eventName = (browser.isInternetExplorer && browser.version.major > 11) ? 'webkitTransitionEnd' : 'transitionend';

jsEvent.callMethod('initEvent', [eventName, true, true]);

Expand Down
4 changes: 2 additions & 2 deletions test/wsd_test_util/common_component_tests.dart
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import 'dart:html';
])
import 'dart:mirrors';

import 'package:browser_detect/browser_detect.dart';
import 'package:platform_detect/platform_detect.dart';
import 'package:over_react/over_react.dart';
import 'package:over_react/src/component_declaration/component_base.dart' as component_base;
import 'package:react/react_client.dart';
Expand Down Expand Up @@ -434,7 +434,7 @@ void commonComponentTests(BuilderOnlyUiFactory factory, {
skippedPropKeys = flatten(skippedPropKeys).toList();

// TODO: Remove this short-circuit when UIP-1125.
if (browser.isIe && browser.version <= '10') return;
if (browser.isInternetExplorer && browser.version.major <= 10) return;

if (shouldTestPropForwarding) {
testPropForwarding(factory, childrenFactory,
Expand Down

0 comments on commit 43aa8b1

Please sign in to comment.