Work around ddev coverage not respecting tags

UIP-2410
Workiva · Jun 20, 2017 · b1a8bda · b1a8bda
1 parent db7d5d0
commit b1a8bda
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/test/over_react/util/ddc_emulated_function_name_bug_test.dart b/test/over_react/util/ddc_emulated_function_name_bug_test.dart
@@ -32,7 +32,11 @@ main() {
             reason: 'if this test fails, then it\'s possible that the bug was fixed in'
                     ' a newer version of the Dart SDK, and this library can be eliminated!'
         );
-      }, tags: 'ddc');
+      }, tags: 'ddc',
+          // Tests run in `ddev coverage` don't respect tags and show up as the 'vm' platform
+          // so we can use this to disable certain browser tests during coverage.
+          // Workaround for https://github.com/Workiva/dart_dev/issues/200
+          testOn: '!vm');
     });
 
     test('patchName fixes instances of a class with the issue in the DDC', () {
@@ -49,7 +53,11 @@ main() {
 
       expect(() => testObject.name = testValue, returnsNormally);
       expect(testObject.name, testValue);
-    }, tags: 'ddc');
+    }, tags: 'ddc',
+        // Tests run in `ddev coverage` don't respect tags and show up as the 'vm' platform
+        // so we can use this to disable certain browser tests during coverage.
+        // Workaround for https://github.com/Workiva/dart_dev/issues/200
+        testOn: '!vm');
   });
 }
 

diff --git a/test/over_react/util/react_wrappers_test.dart b/test/over_react/util/react_wrappers_test.dart
@@ -948,7 +948,11 @@ main() {
           expect(result2, isNot(same(result1)),
               reason: 'if this test fails, then it\'s possible that the bug was fixed in'
                       ' a newer version of the Dart SDK, and this test can be removed!');
-        }, tags: 'ddc');
+        }, tags: 'ddc',
+            // Tests run in `ddev coverage` don't respect tags and show up as the 'vm' platform
+            // so we can use this to disable certain browser tests during coverage.
+            // Workaround for https://github.com/Workiva/dart_dev/issues/200
+            testOn: '!vm');
       });
 
       group('throws when passed', () {