Skip to content

Commit

Permalink
Address CR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
aaronlademann-wf committed Nov 1, 2016
1 parent ba742e8 commit dd869c5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
6 changes: 2 additions & 4 deletions test/over_react/util/handler_chain_util_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,8 @@ main() {
return new List.generate(arity, (_) => new TestGenericType());
}

List<TestGenericType> generateBadTypeArgs() {
// ignore: Type check failed
// ignore: avoid_as
return new List.generate(arity, (_) => new Object() as TestGenericType);
List generateBadTypeArgs() {
return new List.generate(arity, (_) => new Object());
}

group('chain()', () {
Expand Down
2 changes: 1 addition & 1 deletion test/over_react/util/rem_util_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ main() {
'correctly dispatches an event in resopnse to the first change', () async {
expect(querySelector('#rem_change_sensor'), isNull);

List<double> calls = [];
var calls = <double>[];
var listener = onRemChange.listen(calls.add);

expect(querySelector('#rem_change_sensor'), isNotNull);
Expand Down

0 comments on commit dd869c5

Please sign in to comment.