Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIP-1639 Update formatting guidelines WRT dartfmt and trailing commas #25

Open
greglittlefield-wf opened this issue Nov 2, 2016 · 1 comment

Comments

@greglittlefield-wf
Copy link
Contributor

greglittlefield-wf commented Nov 2, 2016

Our formatting guidelines currently recommend against using dartfmt/dart_style on over_react code.

We recently discovered that dartfmt is capable of producing significantly more readable over_react code, due to changes in dart_style that treat Flutter code better when nested components use trailing commas.

For more info, see dart-lang/dart_style#549. Thanks to @skybrian for getting the conversation started, and to @matanlurey for suggesting we revisit the issue!

We should upgrade the formatting guidelines to:

  • recommend trailing commas whenever supplying variadic children to a builder, even if it's just one
  • indicate that dartfmt output, while not perfect, is acceptable when trailing commas are used

FYI: @greglittlefield-wf @aaronlademann-wf @jacehensley-wf @clairesarsam-wf @joelleibow-wf

@rmconsole-wf
Copy link

It looks like you have not included any tickets in the title of this issue. Please create a ticket for this issue, or click here to have Rosie create one for you.

@rmconsole-wf rmconsole-wf changed the title Update formatting guidelines WRT dartfmt and trailing commas UIP-1639 Update formatting guidelines WRT dartfmt and trailing commas Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants