UIP-1639 Update formatting guidelines WRT dartfmt and trailing commas #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RavenNumber of Findings: 0 |
Current coverage is 97.44% (diff: 100%)@@ master #37 diff @@
==========================================
Files 27 27
Lines 1286 1286
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1253 1253
Misses 33 33
Partials 0 0
|
| > | ||
| > _We have a long-term goal of writing our own formatter that extends from `dartfmt` to make it possible for our | ||
| > fluent-style to remain readable even after the formatter executes._ | ||
| #### dart_style |
There was a problem hiding this comment.
#nit shouldn't this be an h3?
There was a problem hiding this comment.
Idk, I made it an h4 so it'd look less important 😄 . Didn't want to take away from the meat of this section: the formatting guidelines.
I can change it to be more consistent, though
There was a problem hiding this comment.
@greglittlefield-wf I'd say - to make it look less important - just use bold text instead of a heading?
There was a problem hiding this comment.
Addressed in 2fb8625
aaronlademann-wf
approved these changes
Jan 4, 2017
|
+1 |
|
+1 |
|
QA +10
merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimate problem:
Formatting guidelines were outdated when it came to trailing commas. (#25)
How it was fixed:
Update them.
Testing suggestions:
Potential areas of regression: