Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIP-2546 Release OverReact 1.15.1 #102

Merged
merged 3 commits into from
Aug 3, 2017

Conversation

aaronlademann-wf
Copy link
Contributor

Dependency Updates

  • over_react_test ^1.1.1 (was ^1.0.1)

Tech Debt


FYA: @Workiva/ui-platform-pp

@aviary-wf
Copy link

aviary-wf commented Aug 3, 2017

Raven

Number of Findings: 0

CHANGELOG.md Outdated

__Dependency Updates__

* over_react_test `^1.1.1` (was `^1.0.1`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really worth calling out in the release notes since it's a dev dependency change? It doesn't affect consumers whatsoever

@greglittlefield-wf
Copy link
Contributor

+1

@codecov-io
Copy link

Codecov Report

Merging #102 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #102   +/-   ##
=======================================
  Coverage   94.34%   94.34%           
=======================================
  Files          31       31           
  Lines        1537     1537           
=======================================
  Hits         1450     1450           
  Misses         87       87

@greglittlefield-wf
Copy link
Contributor

+1

@leviwith-wf
Copy link
Contributor

QA +1

  • Dev +1’s on MPR
  • Dev +1’s present on related CRs
  • Version info updated
  • Rosie ran / comment displays expected info
  • Dependency Scan Clean

Ready for merge and tag.

@leviwith-wf leviwith-wf merged commit a341ce8 into Workiva:master Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants