Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIP-2614 Update UiComponent to implement DisposableManagerV6 #104

Conversation

todbachman-wf
Copy link
Member

@todbachman-wf todbachman-wf commented Aug 10, 2017

Ultimate problem:

Version 1.8.0 of w_common includes a new version of the disposable manager interface that UiComponent implements.

How it was fixed:

  • Upgraded the minimum w_common version to 1.8.0
  • Updated UiComponent to implement DisposableManagerV6

Testing suggestions:

  • Confirm CI passes

Potential areas of regression:

🤷‍♂️


FYA: @greglittlefield-wf @aaronlademann-wf @jacehensley-wf @clairesarsam-wf @joelleibow-wf

@aviary-wf
Copy link

aviary-wf commented Aug 10, 2017

Raven

Number of Findings: 0

@todbachman-wf todbachman-wf force-pushed the uip-2614_implement_disposable_mgr_v6 branch from 88568a6 to 68724e0 Compare August 10, 2017 18:44
@codecov-io
Copy link

codecov-io commented Aug 10, 2017

Codecov Report

Merging #104 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
+ Coverage   94.34%   94.36%   +0.02%     
==========================================
  Files          31       31              
  Lines        1537     1540       +3     
==========================================
+ Hits         1450     1453       +3     
  Misses         87       87

@todbachman-wf todbachman-wf force-pushed the uip-2614_implement_disposable_mgr_v6 branch from 68724e0 to 74cc883 Compare August 10, 2017 19:02
@jacehensley-wf
Copy link
Contributor

+1

@greglittlefield-wf
Copy link
Contributor

+1

@aaronlademann-wf
Copy link
Contributor

QA +10

  • Testing instruction
    • Tested locally with WSD - examples compile in dartium and chrome using both dart2js and ddc.
    • Tested locally with home (to verify folks who are actually using Disposables aren't broken) - app works in dartium, and compiles / runs using dart2js
  • Dev +1's
  • Dev/QA +10
  • Unit tests created/updated
  • All unit tests pass
  • Rosie ran/Rosie comment displays expected info
  • Dependency Scan Clean

Merging.

@aaronlademann-wf aaronlademann-wf merged commit df59869 into Workiva:master Aug 11, 2017
@todbachman-wf todbachman-wf deleted the uip-2614_implement_disposable_mgr_v6 branch August 11, 2017 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants