UIP-2629 getDartComponent warning for ReactElements #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RavenNumber of Findings: 0 |
greglittlefield-wf
force-pushed
the
getDartComponent-warning
branch
from
d88ddc2 to
473b043
Compare
rmconsole2-wf
changed the title
jacehensley-wf
approved these changes
Aug 11, 2017
lib/src/util/react_wrappers.dart
Outdated
| @@ -280,6 +280,43 @@ react.Component getDartComponent(/* [1] */ instance) { | |||
| return null; | |||
| } | |||
|
|
|||
| // Split out into a separate function since the DDC doesn't support | |||
There was a problem hiding this comment.
This actually isn't needed now that I understand the issue more. See dart-lang/sdk#30426
|
+1 |
| sharedInputGetSelectionStartTest(type); | ||
| }, testOn: 'js && !chrome'); | ||
| sharedInputGetSelectionStartTest(type, shouldReturnNull: false); | ||
| }, testOn: '!(blink || firefox)'); |
There was a problem hiding this comment.
I don't think this is working
There was a problem hiding this comment.
Ugh, it's because coverage doesn't include the platform: Workiva/dart_dev#200. I'll apply a fix for that
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
==========================================
+ Coverage 94.36% 94.37% +0.02%
==========================================
Files 31 31
Lines 1540 1543 +3
==========================================
+ Hits 1453 1456 +3
Misses 87 87 |
|
+1 |
|
QA +10
Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimate problem:
The soon to be released react-dart 4.0 will no longer support retrieving Dart components via
getDartComponentfromReactElements(pre-mounted VDOM instances) in order to avoid memory leaks.We should have a warning in place for when this occurs so that consumers will:
How it was fixed:
getDartComponentBoy-scouted:
Testing suggestions:
Verify that tests pass in all platforms:
ddev test -p content-shellddev test -p dartiumddev test -p chromeddev test -p firefoxgetActiveElementtest in masterddev test -p chrome --web-compiler=dartdevc test/*_test.dart -x no-ddcgetActiveElementtest in masterObjectDisposedExceptiontest in masterPotential areas of regression:
getDartComponentsetSelectionRange/getSelectionRange`