Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIP-2806: Release over_react 1.19.0 #127

Merged
merged 3 commits into from
Dec 8, 2017

Conversation

jacehensley-wf
Copy link
Contributor

@jacehensley-wf jacehensley-wf commented Dec 6, 2017

Pulls Included in Release:

Diff Between Last Tag and Proposed Release: 1.18.1...jacehensley-wf:release_1_19_0
Diff Between Last Tag and New Tag: 1.18.1...1.19.0

@aviary2-wf
Copy link

aviary2-wf commented Dec 6, 2017

Raven

Number of Findings: 0

@codecov-io
Copy link

codecov-io commented Dec 6, 2017

Codecov Report

Merging #127 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #127   +/-   ##
=======================================
  Coverage   94.44%   94.44%           
=======================================
  Files          32       32           
  Lines        1581     1581           
=======================================
  Hits         1493     1493           
  Misses         88       88

CHANGELOG.md Outdated

__Tech Debt__
* [#126]: Use dependency_validator.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add a note about the updated SDK version constraint?

CHANGELOG.md Outdated
> [Complete `1.19.0` Changeset](https://github.com/Workiva/over_react/compare/1.18.1...1.19.0)

__New Features__
* [#118] Add `BuiltReduxUiComponent` and `BuiltReduxUiProps`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably mention here that these are considered unstable and found in package:over_react/experimental.dart

@greglittlefield-wf
Copy link
Contributor

+1

@garywhitlock-wf
Copy link

@jacehensley-wf Can you let @kaitlynchilders-wk know when this is merged? We will be bumping the version of over_react in DT tomorrow.

@jayudey-wf
Copy link
Contributor

QA Resource Approval: +1

  • Dev +1's only needed for Release ticket

Ready for merge and tag.

@Workiva/release-management-pp

@jayudey-wf jayudey-wf merged commit ffca459 into Workiva:master Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants