Add an option to make BuiltReduxUiComponent "pure" #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RavenNumber of Findings: 0MagpieNumber of findings: 0 |
Codecov Report
@@ Coverage Diff @@
## master #140 +/- ##
=========================================
- Coverage 94.54% 94.5% -0.03%
=========================================
Files 33 33
Lines 1591 1599 +8
=========================================
+ Hits 1504 1511 +7
- Misses 87 88 +1 |
|
+10
|
greglittlefield-wf
requested changes
Feb 20, 2018
| @@ -85,6 +92,19 @@ abstract class BuiltReduxUiComponent< | |||
| _tearDownSub(); | |||
| } | |||
|
|
|||
| @override | |||
There was a problem hiding this comment.
Should this have a mustCallSuper?
| @@ -145,6 +165,13 @@ abstract class BuiltReduxUiComponent< | |||
| /// Related: [connectedState] | |||
| Substate connect(V state); | |||
|
|
|||
| /// Whether the component should be a "pure" component. | |||
| /// | |||
| /// A "pure" component will only re-render when [connectedState] is updated or [redraw] is called directly. | |||
There was a problem hiding this comment.
Or when the store changes, right?
Should there also be a note showing usage of this? For example:
/// To enable this functionality, override this getter in a subclass to return `true`.
///
/// When using this, do not override [redraw] or [shouldComponentUpdate].| component.redraw(); | ||
|
|
||
| expect(component.numberOfRedraws, 2); | ||
| }); |
There was a problem hiding this comment.
There should also be a test that it updates as expected when props.store changes.
|
|
||
| jacket.rerender((TestDefault() | ||
| ..store = store | ||
| ..id = 'new id' |
There was a problem hiding this comment.
Is the purpose of this ID to change some unrelated props when rerendering? If so, it might be nice to call that out explicitly, perhaps in the reason of the next expect.
expect(component.numberOfRedraws, 1,
reason: 'should not redraw when rerendered, even if other props change');| expect(component.numberOfRedraws, 1); | ||
| }); | ||
|
|
||
| test('when calling redraw', () { |
There was a problem hiding this comment.
#nit this looks like a duplicate test
greglittlefield-wf
approved these changes
Feb 20, 2018
maxwellpeterson-wf
approved these changes
Feb 20, 2018
|
QA +1
Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimate problem:
Implementing a "pure" component by extending
BuiltReduxUiComponentproved to not be possible without making certain methods public and overridable.How it was fixed:
isPuregetter that, when returnstrue, makes the component implementshouldComponentUpdateand only redraw whenconnectedStateis changed.Testing suggestions:
Potential areas of regression: