Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster isNotEmpty on collection #188

Merged
merged 1 commit into from
Oct 3, 2018

Conversation

teresy
Copy link
Contributor

@teresy teresy commented Oct 2, 2018

Ultimate problem:

Looks like this can be isNotEmpty instead (https://www.dartlang.org/guides/language/effective-dart/usage#dont-use-length-to-see-if-a-collection-is-empty)

How it was fixed:

Uses isNotEmpty check.

Testing suggestions:

CI/tests pass.

Potential areas of regression:


FYA: @greglittlefield-wf @aaronlademann-wf @kealjones-wk @evanweible-wf @maxwellpeterson-wf

@teresy teresy requested a review from a team as a code owner October 2, 2018 17:03
@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on HipChat: InfoSec Forum.

@codecov-io
Copy link

Codecov Report

Merging #188 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #188   +/-   ##
=======================================
  Coverage   94.44%   94.44%           
=======================================
  Files          34       34           
  Lines        1617     1617           
=======================================
  Hits         1527     1527           
  Misses         90       90

Copy link
Contributor

@aaronlademann-wf aaronlademann-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Thanks for the contribution @teresy !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants