Bump minimum sdk version from 1.17.1 to 1.19.1 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Will greatly ease the strong-mode transition
RavenNumber of Findings: 0 |
Current coverage is 97.03% (diff: 100%)@@ master #23 diff @@
==========================================
Files 27 27
Lines 1211 1211
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1175 1175
Misses 36 36
Partials 0 0
|
|
+1 |
|
@leviwith-wf this is ready for QA + Merge |
|
QA +10
Merging. |
|
RM +1 manually reviewed dependencies |
greglittlefield-wf
added a commit
that referenced
this pull request
Jun 23, 2020
Lint to warn users when elements within an iterable lacks a key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimate problem:
Dart SDK version 1.19.1 introduces the ability to have trailing commas in argument lists, which will make re-ordering components in our fluent style much less error-prone for consumers.
It also removes the need for a couple of gross type casts we were doing in #15.
How it was fixed:
Updated the sdk constraint in
pubspec.yaml,integrate/pubspec.yaml, and in the Travis CI configuration.Testing suggestions:
Verify that all tests pass.
Potential areas of regression:
None expected.