Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPLAT-4360: Set auto_apply to dependents #251

Merged
merged 1 commit into from
Feb 21, 2019
Merged

Conversation

corwinsheahan-wf
Copy link
Contributor

@corwinsheahan-wf corwinsheahan-wf commented Feb 21, 2019

Ultimate problem:

The over_react builder actually only needs to apply to packages which specify over_react as a direct dependency. This will speed up build times, especially for packages with many dependencies. This was trialed in a fairly large internal repo, and a build with just the over_react builder running completed in ~35s vs ~1m30s without this change.

How it was fixed:

change auto_apply to dependents

Testing suggestions:

  • CI Passes
  • Publink this over_react branch into this branch of web_skin_dart and run pub run build_runner build. Verify that a build succeeds.

Potential areas of regression:


FYA: @greglittlefield-wf @aaronlademann-wf @evanweible-wf @maxwellpeterson-wf @sebastianmalysa-wf @seanburke-wf @smaifullerton-wk

@corwinsheahan-wf corwinsheahan-wf requested a review from a team as a code owner February 21, 2019 19:02
@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@corwinsheahan-wf
Copy link
Contributor Author

QA +1

  • CI Passes
  • Build runs successfully in internal package

Merging into master.
@Workiva/release-management-p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants