CPLAT-4674: Add workaround for ddc bug via props/state impl constructor #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
…round_unknown_ddc_bug
evanweible-wf
approved these changes
Mar 3, 2019
greglittlefield-wf
approved these changes
Mar 4, 2019
| ..writeln(' // This initializer of `_props` to an empty map, as well as the reassignment') | ||
| ..writeln(' // of `_props` in the constructor body is necessary to work around an unknown ddc issue.') | ||
| ..writeln(' // See <https://jira.atl.workiva.net/browse/CPLAT-4673> for more details') | ||
| ..writeln(' $implName(Map backingMap) : this._props = {} {') |
There was a problem hiding this comment.
Just thought of one thing; have you tried initializing to null instead?
Would be nice to avoid this object creation if it's easy to; no big deal if it's a pain to try out, though.
Suggested change
| ..writeln(' $implName(Map backingMap) : this._props = {} {') | |
| ..writeln(' $implName(Map backingMap) : this._props = null {') |
There was a problem hiding this comment.
Unfortunately this doesn't work in ddc.
| main() { | ||
| test('sets private props correctly in `getDefaultProps`', () { | ||
| var instance = render((Foo() | ||
| ..stringProp = 'some string value' |
There was a problem hiding this comment.
#nit this prop is unused
evanweible-wf
approved these changes
Mar 4, 2019
QA +1
|
|
@Workiva/release-management-p for merge into master |
This was referenced Mar 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimate problem:
There's an unknown ddc bug that affects private props/state members and classes. What we know so far: https://jira.atl.workiva.net/browse/CPLAT-4673
How it was fixed:
See https://jira.atl.workiva.net/browse/CPLAT-4673
Testing suggestions:
Potential areas of regression:
Pretty much everything.