Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPLAT-2272: Add UiComponent2 (JS-backed maps) #271

Merged
merged 43 commits into from
Mar 20, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
dc7a13d
Update dart2js flags for testing
greglittlefield-wf Aug 23, 2018
9b47b97
Support Component2
greglittlefield-wf Aug 23, 2018
4208192
Optimize typed props caching
greglittlefield-wf Aug 23, 2018
6f32516
Optimize props so that dart2js knows it's always using a JsBackedMap
greglittlefield-wf Aug 23, 2018
81fd68f
Optimize cachedTypedProps impl
greglittlefield-wf Aug 23, 2018
cce8d79
Get $index to output
greglittlefield-wf Aug 23, 2018
300a0f8
Merge remote-tracking branch 'origin/master' into js_map_perf/dev
greglittlefield-wf Mar 5, 2019
16af7aa
Update Component2 check
greglittlefield-wf Mar 5, 2019
54cd8d2
Fix generated code errors/lints
greglittlefield-wf Mar 5, 2019
2e5faa3
Fix Component2 props/state type errors
greglittlefield-wf Mar 5, 2019
efbf79a
Fix bad equality check, update to latest react-dart branch
greglittlefield-wf Mar 6, 2019
eb25e3b
Commit generated files
greglittlefield-wf Mar 6, 2019
5857ed6
Merge remote-tracking branch 'origin/master' into js_map_perf/dart2
greglittlefield-wf Mar 8, 2019
5933fb8
Get JS-backed maps working for state, conditionally generate code for…
greglittlefield-wf Mar 13, 2019
320f273
Commit generated code
greglittlefield-wf Mar 13, 2019
a67049c
Fix tests that use non-resolved AST
greglittlefield-wf Mar 13, 2019
4a1dc43
Improve ordering of generated props impl members
greglittlefield-wf Mar 13, 2019
b1b62f5
Further updates to generated code to improve readability and restore …
greglittlefield-wf Mar 13, 2019
61cf306
Commit generated files
greglittlefield-wf Mar 13, 2019
fc210c4
Remove leftover file
greglittlefield-wf Mar 13, 2019
29d194f
Add notes about inlining and updated constructor bug
greglittlefield-wf Mar 14, 2019
a7fb937
Recommit generated files
greglittlefield-wf Mar 14, 2019
9f5c063
Add integration tests for Component2
greglittlefield-wf Mar 14, 2019
e4665a4
Cleanup
greglittlefield-wf Mar 14, 2019
bc5afbd
Use https dep override so Travis can pub get
greglittlefield-wf Mar 14, 2019
5119634
Commit generated files
greglittlefield-wf Mar 14, 2019
147fcff
Fix typo and commit generated files
greglittlefield-wf Mar 15, 2019
f9c5792
DRY up DisposableManagerV7 impl, update deprecation warnings
greglittlefield-wf Mar 15, 2019
bd62327
Address compoennt_base feedback, organize better
greglittlefield-wf Mar 15, 2019
9c6ae03
Address other feedback, mark TODOs/FIXMEs with "3.0.0-wip"
greglittlefield-wf Mar 15, 2019
96ed5a7
Update CONTRIBUTING and PR_TEMPLATE, remove CODEOWNERS
greglittlefield-wf Mar 15, 2019
8748f82
Merge pull request #277 from Workiva/update-cp-contributing
rmconsole6-wk Mar 17, 2019
2240989
Silence deprecations introduced by 5.0.0-wip, misc cleanup
greglittlefield-wf Mar 18, 2019
da6591d
Add overrides to Component-implemented methods, remove lifecycle-base…
greglittlefield-wf Mar 18, 2019
17fc4d1
Change examples back to UiComponent
greglittlefield-wf Mar 18, 2019
78de0fb
Use both UiComponent and UiComponent2 in web example
greglittlefield-wf Mar 18, 2019
26576c1
Merge remote-tracking branch 'origin/master' into js_map_perf/dart2
greglittlefield-wf Mar 18, 2019
7528758
Regenerate files
greglittlefield-wf Mar 18, 2019
d663b1b
Skip required prop tests
greglittlefield-wf Mar 19, 2019
dd0ef86
Update builder gold files
greglittlefield-wf Mar 19, 2019
0ae6f6a
Add missing skipped tests
greglittlefield-wf Mar 19, 2019
6376bde
Prefix Component2 integration tests
greglittlefield-wf Mar 20, 2019
580604f
Remove deprecated @Required() annotation and related tests
greglittlefield-wf Mar 20, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
227 changes: 0 additions & 227 deletions .github/CONTRIBUTING.md

This file was deleted.

41 changes: 35 additions & 6 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,16 +1,45 @@
## Ultimate problem:
## Motivation
<!-- High-level overview of what you are trying to fix or improve, and why.
Include any relevant background information that reviewers should know. -->

## Changes
<!-- What this PR changes to fix the problem. -->

## How it was fixed:
#### Release Notes
<!-- A concise description of your changes, written in the imperative.
("Fix bug" and not "Fixed bug" or "Fixes bug.") -->

## Review
_[See CONTRIBUTING.md][contributing-review-types] for more details on review types (+1 / QA +1 / +10) and code review process._

## Testing suggestions:
<!-- If you're making a PR from outside of the Client Platform team, then first off, thanks! :)

For open-source contributors, tag @Workiva/app-frameworks and we'll take a look!

## Potential areas of regression:
For Workiva employees:

*** Please refrain from tagging the whole team to prevent extraneous notifications. ***

If you're not sure who from our team should review these changes, then leave this section
blank for now and post a link to the PR in the #support-ui-platform Slack channel.

---
-->

> __FYA:__ @greglittlefield-wf @aaronlademann-wf @kealjones-wk @evanweible-wf @maxwellpeterson-wf
Please review: <!-- Tag people here or via GitHub's "Request Review" feature-->

### QA Checklist
- [ ] Tests were updated and provide good coverage of the changeset and other affected code
- [ ] Manual testing was performed if needed
- [ ] Steps from PR author:
<!-- Call out any specific manual testing instructions here, or omit this section if not applicable -->
- [ ] Anything falling under manual testing criteria [outlined in CONTRIBUTING.md][contributing-manual-testing]

## Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed:
- [ ] A Client Platform member has reviewed these changes
- [ ] There are no unaddressed comments _- this check can be automated if reviewers use the "Request Changes" feature_
- [ ] _For release PRs -_ Version metadata in Rosie comment is correct


[contributing-review-types]: https://github.com/Workiva/over_react/blob/master/CONTRIBUTING.md#review-types
[contributing-manual-testing]: https://github.com/Workiva/over_react/blob/master/CONTRIBUTING.md#manual-testing-criteria
1 change: 0 additions & 1 deletion CODEOWNERS

This file was deleted.

Loading