Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPLAT-6138: Update handler chain utils for dart 2.4 compat #306

Merged
merged 7 commits into from
Jun 19, 2019

Conversation

evanweible-wf
Copy link
Contributor

@evanweible-wf evanweible-wf commented Jun 18, 2019

Closes #304

CPLAT-6138

Issue Status

Motivation

When Dart 2.4 is released (imminent), it comes with a small breaking language change that unfortunately affects the handler chaining utils in this package. @greglittlefield-wf and @georgelesica-wf were able to update them in such a way that works around the breaking change without adversely affecting existing usages.

Changes

  • The CallbackUtil class no longer uses its generic type param (that previously was expected to extend Function) and instead explicitly marks the relevant types in the class body as covariant Function to achieve the same typing.
  • The CallbackUtilNArg classes no longer specify a type param when extending CallbackUtil since it is unused.
  • Run CI on the dart dev channel as well as stable to hopefully illuminate issues like this as early as possible.

Fixes #304

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:
@greglittlefield-wf @georgelesica-wf @aaronlademann-wf

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed
    • Push up a consumer test PR of this branch in WSD and verify that it passes

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Client Platform member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@evanweible-wf evanweible-wf changed the title Update handler chain utils for dart 2.4. compat Update handler chain utils for dart 2.4 compat Jun 18, 2019
@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@rmconsole6-wk rmconsole6-wk changed the title Update handler chain utils for dart 2.4 compat CPLAT-6138 Update handler chain utils for dart 2.4 compat Jun 18, 2019
@charliekump-wf charliekump-wf changed the title CPLAT-6138 Update handler chain utils for dart 2.4 compat CPLAT-6138: Update handler chain utils for dart 2.4 compat Jun 18, 2019
@greglittlefield-wf
Copy link
Contributor

+1 to @evanweible-wf's commits

Copy link
Contributor

@aaronlademann-wf aaronlademann-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@evanweible-wf
Copy link
Contributor Author

QA +1

@evanweible-wf
Copy link
Contributor Author

+1 to @greglittlefield-wf's commits

@evanweible-wf
Copy link
Contributor Author

@Workiva/release-management-p

@rmconsole2-wf rmconsole2-wf merged commit 6b03b98 into master Jun 19, 2019
@rmconsole2-wf rmconsole2-wf deleted the evan-doesnt-understand-contravariance branch June 19, 2019 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't build with latest dart beta
6 participants