Stateful component mixin #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RavenNumber of Findings: 0 |
Current coverage is 97.43% (diff: 100%)@@ master #38 diff @@
==========================================
Files 27 27
Lines 1286 1283 -3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 1253 1250 -3
Misses 33 33
Partials 0 0
|
|
|
||
| /// A mixin that adds support for strongly-typed state to a [UiComponent]. | ||
| abstract class UiStatefulMixin<TState extends UiState> | ||
| // Implement react.Component instead of UiComponent so we don't run into https://github.com/dart-lang/sdk/issues/14729 |
There was a problem hiding this comment.
Would it be cleaner to notate this in the doc comment instead?
There was a problem hiding this comment.
I don't think so, unless you think this information is beneficial to the audience of the doc comment.
| @@ -91,7 +91,7 @@ typedef TProps BuilderOnlyUiFactory<TProps extends UiProps>(); | |||
| /// | |||
| /// Extends [react.Component]. | |||
| /// | |||
| /// Related: [UiStatefulComponent] | |||
| /// For strongly-typed state, mix in [UiStatefulMixin] or extend from [UiStatefulComponent]. | |||
There was a problem hiding this comment.
Would it be fair to say that using UiStatefulMixin is considered best practice, instead of extending UiStatefulComponent? If so should we just deprecate UiStatefulComponent?
|
Closing this until issues discussed offline (in dart2js compilation, I believe) around FluxUiComponent are fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #28
Ultimate problem:
Previously, it was impossible to create a new stateful component that extended from a non-stateful component.
This has been worked around by ensuring that the base component was stateful as well, but that isn't always possible (e.g., the component comes from another library).
How it was fixed:
UiStatefulComponentnow implementsUiComponent!FluxUiComponent/FluxUiStatefulComponentby using new mixinFluxUiStatefulComponentnow implements bothFluxUiComponentandUiStatefulComponent!Testing suggestions:
Potential areas of regression:
Advanced component inheritance