CPLAT-8011 Add SafeRenderManager (Dart 1) #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
greglittlefield-wf
force-pushed
the
safe-render-manager_dart1
branch
from
6c8f59c
to
0242e04
Compare
rm-astro-wf
changed the title
Codecov Report
@@ Coverage Diff @@
## master_dart1 #396 +/- ##
================================================
+ Coverage 90.53% 90.67% +0.15%
================================================
Files 36 38 +2
Lines 1878 1949 +71
================================================
+ Hits 1700 1767 +67
- Misses 178 182 +4 |
|
@Workiva/release-management-pp |
This was referenced Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dart 1 version of #390 —see that PR for details.
All commits from that PR (other than generated code updates) were cherry-picked without merge conflicts.
Two additional commits were added adding Dart 1 compatibility and fixing tests in Dart 1:
https://github.com/Workiva/over_react/pull/396/files/b9f81fb542de38f7cabfb9cf5c2908429b4e7961..0242e043715861d8e0d9f850f5c8ac575598e4ea