-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UIP-1976, UIP-1975 Release over_react 1.5.0 (HOTFIX) #46
Merged
leviwith-wf
merged 6 commits into
Workiva:master
from
greglittlefield-wf:resize_sensor_quick_mount
Jan 30, 2017
Merged
UIP-1976, UIP-1975 Release over_react 1.5.0 (HOTFIX) #46
leviwith-wf
merged 6 commits into
Workiva:master
from
greglittlefield-wf:resize_sensor_quick_mount
Jan 30, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RavenNumber of Findings: 0 |
rmconsole2-wf
changed the title
Copy over ResizeSensor quickMount updates from web_skin_dart
UIP-1975 Copy over ResizeSensor quickMount updates from web_skin_dart
Jan 30, 2017
+1 |
greglittlefield-wf
force-pushed
the
resize_sensor_quick_mount
branch
from
January 30, 2017 17:27
58c6864
to
9c6a0c3
Compare
greglittlefield-wf
changed the title
UIP-1975 Copy over ResizeSensor quickMount updates from web_skin_dart
todo
Jan 30, 2017
+10
|
leviwith-wf
changed the title
UIP-1976 Release over_react 1.5.0 (HOTFIX)
UIP-1976, UIP-1975 Release over_react 1.5.0 (HOTFIX)
Jan 30, 2017
+1 |
QA Resource Approval: +10
Ready for merge and tag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy missing updates from https://github.com/Workiva/web_skin_dart/pull/608
Testing:
Verify that the dynamic-height demo in w_virtual_components master is no longer broken with this dependency override:
Ultimate Problem
ResizeSensor
(especially itscomponentDidMount
) was too slow to use onVirtualList
items in order to support dynamic-height items (UIP-1511).Solution
quickMount
prop toResizeSensor
, which minimizes layouts caused by accessing element dimensions. When enabled:onResize
event will contain0
for the previous dimensions.onInitialize
will never be called.props.quickMount
Semi-unrelated changes