CPLAT-12081 Readme Improvements #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
greglittlefield-wf
requested changes
Jun 2, 2020
…provements # Conflicts: # README.md
+ Change http links to https + Add a README file to the root of example to satisfy example requirements (https://dart.dev/tools/pub/package-layout#examples)
|
Sorry I lost track of this @greglittlefield-wf - all feedback has been addressed. |
# Conflicts: # README.md
aaronlademann-wf
force-pushed
the
readme-improvements
branch
from
8edcb09
to
c499377
Compare
greglittlefield-wf
approved these changes
Sep 3, 2020
rmconsole-wf
added
RM Ready
Merge Requirements Met
and removed
Merge Requirements Unmet
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As I was doing a full in-depth read through our README this morning following the awesome 3.5.0 release, I noticed a few things that were wrong, or that just needed a little love/updating.
Changes
Misc. updates and improvements to the README. I broke it all up into fairly granular commits if you want to digest the changes that way.
Release Notes
Improve documentation
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review: @greglittlefield-wf @sydneyjodon-wk @joebingham-wk
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: