Skip to content

Conversation

@jacehensley-wf
Copy link
Contributor

Ultimate problem:

There was a strong mode warning on a typedef on Dart 1.22.0.

How it was fixed:

  • Add a type parameter to base_component.UiComponent.

Testing suggestions:

  • Verify that there are no analyzer warnings on Dart 1.22.0

Potential areas of regression:

N/A


FYA: @greglittlefield-wf @aaronlademann-wf @jacehensley-wf @clairesarsam-wf @joelleibow-wf

@aviary-wf
Copy link

Raven

Number of Findings: 0

@codecov-io
Copy link

Codecov Report

Merging #54 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #54   +/-   ##
=======================================
  Coverage   97.71%   97.71%           
=======================================
  Files          28       28           
  Lines        1352     1352           
=======================================
  Hits         1321     1321           
  Misses         31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdb035f...79453fd. Read the comment docs.

@greglittlefield-wf
Copy link
Contributor

+1

@rmconsole-wf rmconsole-wf changed the title Fix strong mode warning UIP-2120 Fix strong mode warning Mar 10, 2017
@aaronlademann-wf
Copy link
Contributor

aaronlademann-wf commented Mar 16, 2017

  • Testing instruction
  • Dev +1's
  • Dev/QA +10
  • Unit tests created/updated
  • All unit tests pass
  • Rosie ran/Rosie comment displays expected info
  • Dependency Scan Clean

Merging.+10

@aaronlademann-wf aaronlademann-wf merged commit 9726269 into Workiva:master Mar 16, 2017
greglittlefield-wf pushed a commit that referenced this pull request Jun 19, 2020
Format recently merged changes, enforce formatting in CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants