Validate part directive for libs with parts #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corwinsheahan-wf
requested review from
greglittlefield-wf,
evanweible-wf,
sydneyjodon-wk,
luisgomez-wk and
joebingham-wk
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
… into link-2020/validate_generated_part_for_parent
greglittlefield-wf
requested changes
Jun 25, 2020
tools/analyzer_plugin/lib/src/diagnostic/boilerplate_validator.dart
Outdated
Show resolved
Hide resolved
tools/analyzer_plugin/lib/src/diagnostic/boilerplate_validator.dart
Outdated
Show resolved
Hide resolved
| @@ -67,6 +87,8 @@ class BoilerplateValidatorDiagnostic extends DiagnosticContributor { | |||
| // Do not lint anything that is not a likely boilerplate member that will actually get generated. | |||
| if (member.versionConfidences.toList().every((vcp) => vcp.confidence <= Confidence.neutral)) continue; | |||
|
|
|||
| if (isPart(result.unit)) continue; | |||
There was a problem hiding this comment.
Because of this, there's no error if components are declared in parts and there's no generated import in the main library.
Sorry, I can't remember; we going to handle that case in a separate PR?
There was a problem hiding this comment.
For posterity: we'll handle this separately
|
QA +1 |
greglittlefield-wf
approved these changes
Jun 29, 2020
aaronlademann-wf
deleted the
link-2020/validate_generated_part_for_parent
branch
2 tasks
| @@ -238,3 +229,11 @@ extension<E> on Iterable<E> { | |||
| }); | |||
| } | |||
| } | |||
|
|
|||
| // TODO use the version from over_react instead after initial release | |||
There was a problem hiding this comment.
Added #585 to address this TODO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #522
Motivation
The boiler plate validation logic doesn't currently account or the case where the component declarations are in a
part offile.Changes
part of, just run the boilerplate validation, but not any part directive validation.Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: