Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export react-dart members and add capturing event handlers #61

Merged
merged 2 commits into from
Apr 17, 2017

Conversation

clairesarsam-wf
Copy link
Contributor

Ultimate problem:

  • Using synthetic event classes required importing react:react.dart in addition to over_react:over_react.dart.
  • Using setClientConfiguration and ReactElement required importing react:react_client.dart.
  • ReactJS supports capturing event handlers (briefly mentioned here) and so does react-dart, but OverReact didn't.

How it was fixed:

  • Export synthetic event classes (this doesn't generate any warnings/infos for consumers already importing react:react.dart.
  • Export setClientConfiguration and ReactElement.
  • Add capturing event handlers to DomPropsMixin.

Testing suggestions:

  • Consume this branch in WSD and note no issues occur.

Potential areas of regression:

None.


FYA: @greglittlefield-wf @aaronlademann-wf @jacehensley-wf @clairesarsam-wf @joelleibow-wf

@aviary-wf
Copy link

Raven

Number of Findings: 0

@codecov-io
Copy link

Codecov Report

Merging #61 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
+ Coverage   97.73%   97.75%   +0.02%     
==========================================
  Files          28       28              
  Lines        1365     1374       +9     
==========================================
+ Hits         1334     1343       +9     
  Misses         31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1986adf...6f7040d. Read the comment docs.

@aaronlademann-wf
Copy link
Contributor

aaronlademann-wf commented Apr 17, 2017

QA +10

  • Testing instruction
  • Dev +1's
  • Dev/QA +10
  • Unit tests created/updated
  • All unit tests pass
  • Rosie ran/Rosie comment displays expected info
  • Dependency Scan Clean

@jacehensley-wf
Copy link
Contributor

+1

@aaronlademann-wf aaronlademann-wf merged commit b49b348 into Workiva:master Apr 17, 2017
greglittlefield-wf added a commit that referenced this pull request Jun 24, 2020
Add Assist for Toggling Component Statefulness
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants