Use propsOrStateMapsEqual in memo so that tearoffs don't cause unnecessary rerenders #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ So that Dart tear-off functions passed as prop values do not cause unexpected re-render(s) when a function component is wrapped with `memo`.
aaronlademann-wf
requested review from
greglittlefield-wf,
joebingham-wk and
sydneyjodon-wk
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
greglittlefield-wf
approved these changes
Nov 17, 2020
rmconsole-wf
added
RM Ready
Merge Requirements Met
and removed
Merge Requirements Unmet
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Tearoffs aren't guaranteed to be identical, and we don't want the use of them to trigger unnecessary rerenders in
memoized function components.Closely related to how we handled this same problem for
connected componentsChanges
propsOrStateMapsEqualforareEqualinstead of default JS equality when the consumer does not specify their own custom handler for theareEqualparameter.memo.