CPLAT-12196: @Component2 annotation parity for function components

[greglittlefield-wf]

Motivation

The @Component2 annotation can't be used with function components, preventing consumers from specifying arguments like isWrapper and subtypeOf.

Changes

• Add setTypeMeta extension method to UiFactory, providing parity with the @Component2 annotation for function components
  • Add tests
• Tweak arguments to private setComponentTypeMeta and ComponentTypeMeta to use raw component types in case the ReactComponentFactoryProxy isn't available
  • Increase test coverage for these utilities

Examples of equivalent configuration for class-based vs function components:

// Class components:

@Component2(isWrapper: true)
class FooComponent extends UiComponent2<FooProps> { ... }

@Component2(subtypeOf: FooComponent)
class BarComponent ... {...}

// Function components:

UiFactory<FooProps> Foo = uiFunction(...)
  ..setComponentMeta(isWrapper: true);

UiFactory<FooProps> Bar = uiFunction(...)
  ..setComponentMeta(subtypeOfFactory: Foo);

Release Notes

• Add extension method UiFactory.setComponentMeta, which brings @Component2 annotation configuration to function components

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

• Tests were updated and provide good coverage of the changeset and other affected code
• Manual testing was performed if needed
  • Steps from PR author:
    • Ensure test branch WSD is passing: https://github.com/Workiva/web_skin_dart/pull/1537
      • WSD has extensive usage of component subtyping, and is a good place to test for regressions related to these changes
  • Anything falling under manual testing criteria outlined in CONTRIBUTING.md

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

• A Client Platform member has reviewed these changes
• There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
• For release PRs - Version metadata in Rosie comment is correct

[aviary3-wk]

Security Insights

No security relevant content was detected by automated scans.

Action Items

• Review PR for security impact; comment "security review required" if needed or unsure
• Verify aviary.yaml coverage of security relevant code

---

Questions or Comments? Reach out on Slack: #support-infosec.

[greglittlefield-wf]

This shared suite still exists, I just moved some tests out of it that didn't make sense to be shared

[aaronlademann-wf]

+1

[aaronlademann-wf]

Was this something you discovered was not working correctly - or is this necessary for these changes to work?

[greglittlefield-wf]

It was working fine before; this was necessary since I changed setComponentTypeMeta, a private API, to expect the raw type instead of the proxy.

[joebingham-wk]

+1! And I can QA in the morning!

[sydneyjodon-wk]

It looks like some related tests are failing.

[greglittlefield-wf]

All issues have been addressed!

[joebingham-wk]

+10

• code looks good
• QA'd by:
  • Ensuring wsd test branch passes with latest changes
  • Mimicked a WSD subtype example to verify it worked as expected

[greglittlefield-wf]

@Workiva/release-management-p

[rmconsole-wf]

+1 from RM