Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIP-2260 Release over_react 1.9.1 (HOTFIX) #66

Merged
merged 2 commits into from
May 3, 2017

Conversation

greglittlefield-wf
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf commented May 3, 2017

Ultimate problem:

Consumers of AbstractTransition (like OverlayRenderer) that didn't call super.componentDidMount stopped working properly in over_react 1.9.0: transitions never completed.

How it was fixed:

Remove componentDidMount requirement as a quick fix.

Testing suggestions:

Pull in this version of over_react, and verify that overlay DOM gets cleaned up when overlays (e.g., web_skin_dart Alerts, Popovers, etc.) are transitioned out:

dependency_overrides:
  over_react:
    git:
      url: git@github.com:Workiva/over_react.git
      ref: 1f41e0b20a335264bdd60372f34d90199bb0d20c # from transition_hotfix

Potential areas of regression:

Overlay setState warnings.


@aviary-wf
Copy link

Raven

Number of Findings: 0

@rmconsole3-wf rmconsole3-wf changed the title Release over_react 1.9.1 (HOTFIX) WP-4045 UIP-2260 Release over_react 1.9.1 (HOTFIX) May 3, 2017
@greglittlefield-wf greglittlefield-wf changed the title WP-4045 UIP-2260 Release over_react 1.9.1 (HOTFIX) UIP-2260 Release over_react 1.9.1 (HOTFIX) May 3, 2017
@codecov-io
Copy link

Codecov Report

Merging #66 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
- Coverage   97.69%   97.69%   -<.01%     
==========================================
  Files          28       28              
  Lines        1381     1380       -1     
==========================================
- Hits         1349     1348       -1     
  Misses         32       32

@clairesarsam-wf
Copy link
Contributor

+1

@patrickoconnor-wf
Copy link

+10 from Home

  • Verified that modal backdrop is gone after hiding a modal.

@aaronlademann-wf
Copy link
Contributor

QA +10

  • Testing instruction
  • Dev +1's
  • Dev/QA +10
  • Unit tests created/updated
  • All unit tests pass
  • Rosie ran/Rosie comment displays expected info
  • Dependency Scan Clean

Merging.

@aaronlademann-wf aaronlademann-wf merged commit ada853b into master May 3, 2017
@greglittlefield-wf greglittlefield-wf deleted the transition_hotfix branch May 23, 2017 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants