UIP-2260 Release over_react 1.9.1 (HOTFIX) #66
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimate problem:
Consumers of AbstractTransition (like
OverlayRenderer
) that didn't callsuper.componentDidMount
stopped working properly in over_react 1.9.0: transitions never completed.How it was fixed:
Remove
componentDidMount
requirement as a quick fix.Testing suggestions:
Pull in this version of over_react, and verify that overlay DOM gets cleaned up when overlays (e.g., web_skin_dart Alerts, Popovers, etc.) are transitioned out:
Potential areas of regression:
Overlay
setState
warnings.