Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIP-2298 Include explicitly-used transitive imports, as warned by pub publish #68

Merged
merged 1 commit into from
May 18, 2017

Conversation

greglittlefield-wf
Copy link
Contributor

Ultimate problem:

When running pub publish, there were warnings about libraries being used but not declared as dependencies:

Suggestions:
* line 21, column 1 of lib/src/util/react_wrappers.dart: This package doesn't depend on js.
  import 'package:js/js.dart';
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
* line 23, column 1 of lib/transformer.dart: This package doesn't depend on path.
  import 'package:path/path.dart' as p;
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
* line 17, column 1 of test/over_react/component_declaration/component_type_checking_test.dart: This package doesn't depend on js.
  import 'package:js/js.dart';
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
* line 20, column 1 of test/over_react/util/react_wrappers_test.dart: This package doesn't depend on js.
  import 'package:js/js.dart';
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
* line 21, column 1 of test/test_util/dom_util.dart: This package doesn't depend on browser_detect.
  import 'package:browser_detect/browser_detect.dart';
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
* line 21, column 1 of test/test_util/react_util.dart: This package doesn't depend on js.
  import 'package:js/js.dart';
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
* line 26, column 1 of test/wsd_test_util/common_component_tests.dart: This package doesn't depend on browser_detect.
  import 'package:browser_detect/browser_detect.dart';
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
* line 17, column 1 of test/wsd_test_util/test_js_component.dart: This package doesn't depend on js.
  import 'package:js/js.dart';
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Package has 8 warnings.

How it was fixed:

Add packages to pubspec.yaml.

Testing suggestions:

  • Pull this branch, run pub publish --dry-run, and verify that there are no warnings
  • Verify that pub get completes successfully (should be done by CI)

Potential areas of regression:

Dependencies


FYA: @greglittlefield-wf @aaronlademann-wf @jacehensley-wf @clairesarsam-wf @joelleibow-wf

@aviary-wf
Copy link

Raven

Number of Findings: 0

@codecov-io
Copy link

codecov-io commented May 15, 2017

Codecov Report

Merging #68 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #68   +/-   ##
=======================================
  Coverage   97.69%   97.69%           
=======================================
  Files          28       28           
  Lines        1380     1380           
=======================================
  Hits         1348     1348           
  Misses         32       32

@jacehensley-wf
Copy link
Contributor

+1

@rmconsole-wf rmconsole-wf changed the title Include explicitly-used transitive imports, as warned by pub publish UIP-2298 Include explicitly-used transitive imports, as warned by pub publish May 15, 2017
@leviwith-wf
Copy link
Contributor

QA +10

  • no warnings in pub publish --dry run
  • pub get works

  • Testing instruction
  • Dev +1's
  • Dev/QA +10
  • All unit tests pass
  • Rosie ran/Rosie comment displays expected info
  • Dependency Scan Clean

Merging.

@leviwith-wf leviwith-wf merged commit 84e4921 into master May 18, 2017
@greglittlefield-wf greglittlefield-wf deleted the include_used_dependencies branch May 23, 2017 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants