Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widen Dependency Ranges Blocking Dart 2.13 #695

Merged

Conversation

sourcegraph-wk
Copy link

Motivation

In order for projects to be compatible with Dart 2.13, there are dependencies that need to have their ranges widened.
For a list of dependencies expected to be changed, see the dependencies section of the Dart 2.12+ wiki page.

Another necessary change is the removal of build_vm_compilers. If this is the case, additional clean up may need to be done, such as removing the associated config from build.yaml or updating how tests are run. A member of Client Platform will be following up with PRs that have CI failures to resolve any issues or perform necessary clean up.

For any questions or concerns, don't hesitate to reach us in the #support-client-plat Slack channel!

Changes

  • Update specific dependencies to be compatible with Dart 2.13.
  • Remove build_vm_compilers if it was present

QA

  • CI passes

Created by Sourcegraph batch change Workiva/dart_213_dependency_range_widen.

@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@aaronlademann-wf aaronlademann-wf force-pushed the campaign/client_platform/dart-213-dependency-range-widen branch from 7b16f95 to c7ea908 Compare July 21, 2021 16:53
Copy link
Contributor

@aaronlademann-wf aaronlademann-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI checks that are failing are also failing on master.

+1

Copy link
Contributor

@aaronlademann-wf aaronlademann-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@aaronlademann-wf
Copy link
Contributor

@Workiva/release-management-pp

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rm-astro-wf rm-astro-wf merged commit 08a60d2 into master Jul 21, 2021
@rm-astro-wf rm-astro-wf deleted the campaign/client_platform/dart-213-dependency-range-widen branch July 21, 2021 21:21
aaronlademann-wf added a commit that referenced this pull request Aug 11, 2021
+ To prevent dependency gridlock downstream
+ The 1.1.6 lower bound is what was originally implemented for the Dart 2.13 migration effort (#695), and I accidentally bumped the lower bound to what it was before the 2.13 effort commit not realizing that it was intentionally being lowered.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants