Add 2.13.4 to matrix #708
Add 2.13.4 to matrix #708
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
| @@ -35,7 +35,7 @@ jobs: | |||
|
|
|||
| - name: Verify formatting | |||
| run: pub run dart_dev format --check | |||
| if: always() && ${{ matrix.sdk }} == '2.7.2' && steps.install.outcome == 'success' | |||
| if: always() && matrix.sdk == '2.7.2' && steps.install.outcome == 'success' | |||
There was a problem hiding this comment.
I changed this since this was invalid syntax; if entries are interpolated already (which is why we can do steps.install.outcome on this same line without that interpolation), and adding interpolation within them messes things up.
| @@ -44,9 +44,7 @@ jobs: | |||
| # which could cause analysis issues for consumers who haven't run a build yet. | |||
| dartanalyzer lib | |||
| cd example/boilerplate_versions | |||
| if [ ${{ matrix.sdk }} = '2.7.2' ]; then pub global activate tuneup && tuneup check; fi | |||
| if [ ${{ matrix.sdk }} = 'stable' ]; then echo 'Skip pre-build analysis for Dart versions >=2.9 and <2.12 because there will be analysis errors.'; fi | |||
There was a problem hiding this comment.
This was only relevant when stable was >=2.9<2.12, so I removed it.
| @@ -44,9 +44,7 @@ jobs: | |||
| # which could cause analysis issues for consumers who haven't run a build yet. | |||
| dartanalyzer lib | |||
| cd example/boilerplate_versions | |||
| if [ ${{ matrix.sdk }} = '2.7.2' ]; then pub global activate tuneup && tuneup check; fi | |||
| if [ ${{ matrix.sdk }} = 'stable' ]; then echo 'Skip pre-build analysis for Dart versions >=2.9 and <2.12 because there will be analysis errors.'; fi | |||
| if [ ${{ matrix.sdk }} = 'dev' ]; then cd mixin_based/dart_2_9_compatible && dart analyze; fi | |||
There was a problem hiding this comment.
We no longer have to analyze only mixin_based/dart_2_9_compatible after Dart 2.13 reinstated the ability to ignore analysis errors
|
QA +1. build 2.7.2 and build 2.13.4 are passing. analyzer_plugin 2.7.2 is passing will analyzer_plugin 2.13.4 is failing as expected. We also expect stable and dev to fail for both build and analyzer. |
|
@Workiva/release-management-p |
Motivation
Getting dependencies sorted to the point where we can have a passing Dart 2.14 (
stable) build is proving to be difficult, and we still want to verify that over_react works on Dart 2.13.Changes
Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: