-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPLAT-16343 Auto-tear-down ConnectFluxAdapterStores when backing Flux stores dispose #720
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, just re-running some consumer tests that had difficulties.
EDIT: false alarm, clicked on the wrong links. They are passing 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+10
@Workiva/release-management-p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
Motivation
It's inconvenient to store references to
ConnectFluxAdapterStore
s to callteardown
on them later, especially when using the extension methodasConnectFluxStore
after passing through the Flux store through several layers of constructors/functions.Changes
Automatically call
teardown
on the created store when the backing Flux store disposes, since the Redux store won't be used to dispatch any events anyways after the Flux store has been disposed.Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: