Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPLAT-16343 Auto-tear-down ConnectFluxAdapterStores when backing Flux stores dispose #720

Merged
merged 2 commits into from
Dec 2, 2021

Conversation

greglittlefield-wf
Copy link
Contributor

Motivation

It's inconvenient to store references to ConnectFluxAdapterStores to call teardown on them later, especially when using the extension method asConnectFluxStore after passing through the Flux store through several layers of constructors/functions.

Changes

Automatically call teardown on the created store when the backing Flux store disposes, since the Redux store won't be used to dispatch any events anyways after the Flux store has been disposed.

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Client Platform member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@rmconsole6-wk rmconsole6-wk changed the title Auto-tear-down ConnectFluxAdapterStores when backing Flux stores dispose CPLAT-16343 Auto-tear-down ConnectFluxAdapterStores when backing Flux stores dispose Dec 1, 2021
Copy link
Contributor

@joebingham-wk joebingham-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, just re-running some consumer tests that had difficulties.

EDIT: false alarm, clicked on the wrong links. They are passing 😄

Copy link
Contributor

@joebingham-wk joebingham-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

@greglittlefield-wf
Copy link
Contributor Author

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole2-wf rmconsole2-wf merged commit c16453e into master Dec 2, 2021
@rmconsole2-wf rmconsole2-wf deleted the auto-teardown-adapter-stores branch December 2, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants