Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPLAT-16997 Fix selector hooks redrawing when values haven't changed #730

Merged
merged 20 commits into from
Feb 3, 2022
Merged

CPLAT-16997 Fix selector hooks redrawing when values haven't changed #730

merged 20 commits into from
Feb 3, 2022

Commits on Feb 2, 2022

  1. Fix selectors always returning new objects by conditionally wrapping … 

    …values
    @greglittlefield-wf
    greglittlefield-wf committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    64d087e View commit details
    Browse the repository at this point in the history

  2. Reuse wrapped functions

    @greglittlefield-wf
    greglittlefield-wf committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    c01d310 View commit details
    Browse the repository at this point in the history

  3. Add regression tests

    @greglittlefield-wf
    greglittlefield-wf committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    2c68978 View commit details
    Browse the repository at this point in the history

  4. Fix missing arg causing swallowed RTEs

    @greglittlefield-wf
    greglittlefield-wf committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    5e12f20 View commit details
    Browse the repository at this point in the history

  5. Fix missing arg causing swallowed RTEs for createSelectorHook

    @greglittlefield-wf
    greglittlefield-wf committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    4dfb35d View commit details
    Browse the repository at this point in the history

  6. Add some shared tests for different selected value types

    @greglittlefield-wf
    greglittlefield-wf committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    656cfca View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2022

  1. Add test coverage for createSelector, add null case and additional se… 

    …tup checks
    @greglittlefield-wf
    greglittlefield-wf committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    df95525 View commit details
    Browse the repository at this point in the history

  2. Use typed props

    @greglittlefield-wf
    greglittlefield-wf committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    d472036 View commit details
    Browse the repository at this point in the history

  3. Fix typo

    @greglittlefield-wf
    greglittlefield-wf committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    498c594 View commit details
    Browse the repository at this point in the history

  4. Update typing from dynamic to Object to prevent unintentional implici… 

    …t casts, tidy up
    @greglittlefield-wf
    greglittlefield-wf committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    2e74a56 View commit details
    Browse the repository at this point in the history

  5. Revert changes in old tests

    @greglittlefield-wf
    greglittlefield-wf committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    4202bc5 View commit details
    Browse the repository at this point in the history

  6. Remove unused dependency

    @greglittlefield-wf
    greglittlefield-wf committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    f4f3ae4 View commit details
    Browse the repository at this point in the history

  7. Add more test coverage

    @greglittlefield-wf
    greglittlefield-wf committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    5973053 View commit details
    Browse the repository at this point in the history

  8. Cleanup

    @greglittlefield-wf
    greglittlefield-wf committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    2880847 View commit details
    Browse the repository at this point in the history

  9. Add test coverage for value identity

    @greglittlefield-wf
    greglittlefield-wf committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    7cee6c0 View commit details
    Browse the repository at this point in the history

  10. Add additional test coverage for connect

    @greglittlefield-wf
    greglittlefield-wf committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    abe3425 View commit details
    Browse the repository at this point in the history

  11. Add comment

    @greglittlefield-wf
    greglittlefield-wf committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    e7cabbd View commit details
    Browse the repository at this point in the history

  12. Add useSelector example

    @greglittlefield-wf
    greglittlefield-wf committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    b199497 View commit details
    Browse the repository at this point in the history

  13. Update doc comment to not get flagged by dependency_validator

    @greglittlefield-wf
    greglittlefield-wf committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    b55e993 View commit details
    Browse the repository at this point in the history

  14. Fix copyright headers

    @greglittlefield-wf
    greglittlefield-wf committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    cb65a0e View commit details
    Browse the repository at this point in the history