-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow analyzer 1.0 #736
Allow analyzer 1.0 #736
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
This reverts commit 45612aa.
88a6a9b
to
da63635
Compare
Just 1 suggestion but everything else looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to @robbecker-wf's commits
pubspec.yaml
Outdated
# and Dart 2.12+ needs 0.42.x to resolve to build_web_compilers 2.12.0, etc. | ||
# to enable proper opting out of null-safety. | ||
analyzer: '>=0.39.0 <0.42.0' | ||
analyzer: '>=0.40.0 <2.0.0' | ||
build: '>=1.0.0 <3.0.0' | ||
built_redux: ^7.4.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
built_redux < 8.0.0
does not allow analyzer 1.0. Should this be expanded?
built_redux: ^7.4.2 | |
built_redux: ">=7.4.2 <9.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on this CI run it seems like it does:
Though, I'm not opposed to raising the bound on built_redux so this package isn't a bottleneck. Let me take a look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah we've backpatched built_redux v7 to allow analyzer v1
Co-authored-by: Aaron Lademann <aaron.lademann@workiva.com>
@@ -78,14 +78,14 @@ void main() { | |||
var renderedInstance = render(TestDefault()..store = store); | |||
TestDefaultComponent component = getDartComponent(renderedInstance); | |||
|
|||
store.actions.trigger1(); | |||
store.actions.trigger1(null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The argument to ActionDispatcher
was originally optional but then was made required in built_redux 8.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
+10 verified that all validate_analyzer jobs passed and are using the correct analyzer versions each. |
@Workiva/release-management-p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
Motivation
Allow analyzer 1.0
Changes
Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
pub get
output)Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: