Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow analyzer 1.0 #736

Merged
merged 21 commits into from
May 11, 2022
Merged

Allow analyzer 1.0 #736

merged 21 commits into from
May 11, 2022

Conversation

robbecker-wf
Copy link
Member

@robbecker-wf robbecker-wf commented Feb 23, 2022 •
edited by greglittlefield-wf
Loading

Motivation

Allow analyzer 1.0

Changes

  • Updated some ranges to get closer to resolving analyzer 1.0
  • Add CI checks to validate each supported major version of analyzer

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed
    • Steps from PR author:
      • Verify all new "validate_analyzer" runs pass
      • Verify "validate_analyzer" resolves to the corresponding analyzer major version in each run (see pub get output)
    • Anything falling under manual testing criteria outlined in CONTRIBUTING.md

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Client Platform member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

robbecker-wf
robbecker-wf commented Feb 24, 2022
View reviewed changes
pubspec.yaml Outdated Show resolved Hide resolved
robbecker-wf
robbecker-wf commented Feb 24, 2022
View reviewed changes
pubspec.yaml Outdated Show resolved Hide resolved
@robbecker-wf robbecker-wf marked this pull request as ready for review May 10, 2022 01:04
@robbecker-wf robbecker-wf changed the title WIP Allow analyzer 1.0 Allow analyzer 1.0 May 10, 2022
@robbecker-wf
Copy link
Member Author

Just 1 suggestion but everything else looks good.

greglittlefield-wf
greglittlefield-wf previously approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to @robbecker-wf's commits

aaronlademann-wf
aaronlademann-wf reviewed May 10, 2022
View reviewed changes
pubspec.yaml Outdated
# and Dart 2.12+ needs 0.42.x to resolve to build_web_compilers 2.12.0, etc.
# to enable proper opting out of null-safety.
analyzer: '>=0.39.0 <0.42.0'
analyzer: '>=0.40.0 <2.0.0'
build: '>=1.0.0 <3.0.0'
built_redux: ^7.4.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

built_redux < 8.0.0 does not allow analyzer 1.0. Should this be expanded?

Suggested change
built_redux: ^7.4.2
built_redux: ">=7.4.2 <9.0.0"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on this CI run it seems like it does:
Screen Shot 2022-05-10 at 10 52 37 AM

Though, I'm not opposed to raising the bound on built_redux so this package isn't a bottleneck. Let me take a look

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah we've backpatched built_redux v7 to allow analyzer v1

@greglittlefield-wf @aaronlademann-wf
Raise built_redux upper bound
f582396 
Co-authored-by: Aaron Lademann <aaron.lademann@workiva.com>
greglittlefield-wf
greglittlefield-wf reviewed May 10, 2022
View reviewed changes
test/over_react/component_declaration/redux_component_test.dart
@@ -78,14 +78,14 @@ void main() {
var renderedInstance = render(TestDefault()..store = store);
TestDefaultComponent component = getDartComponent(renderedInstance);

store.actions.trigger1();
store.actions.trigger1(null);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The argument to ActionDispatcher was originally optional but then was made required in built_redux 8.0.0

aaronlademann-wf
aaronlademann-wf approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@aaronlademann-wf aaronlademann-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@robbecker-wf
Copy link
Member Author

+10 verified that all validate_analyzer jobs passed and are using the correct analyzer versions each.

@greglittlefield-wf
Copy link
Contributor

@Workiva/release-management-p

rmconsole-wf
rmconsole-wf approved these changes May 11, 2022
View reviewed changes
Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole3-wf rmconsole3-wf merged commit 334545b into master May 11, 2022
@rmconsole3-wf rmconsole3-wf deleted the analyzer1 branch May 11, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greglittlefield-wf greglittlefield-wf greglittlefield-wf left review comments

@aaronlademann-wf aaronlademann-wf aaronlademann-wf approved these changes

@rmconsole-wf rmconsole-wf rmconsole-wf approved these changes

Assignees
No one assigned
Labels
Merge Requirements Met RM Ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@robbecker-wf @aviary3-wk @greglittlefield-wf @aaronlademann-wf @rmconsole-wf @rmconsole3-wf @robrbecker