-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FED-193 Show Component Name in ErrorBoundary Stack #770
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome! Just a couple minor things
@@ -68,10 +68,6 @@ ReactDartComponentFactoryProxy2 registerComponent2(react.Component2 Function() d | |||
bridgeFactory: UiComponent2BridgeImpl.bridgeFactory, | |||
); | |||
|
|||
if (displayName != null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since displayName
parameter is no longer used, can we deprecate it, and update the builder to no longer pass it in the generated registerComponent2
call?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed! I was planning on leaving registerComponent
alone since that whole stack is deprecated, but I ended up updating that too to avoid unnecessary conditional logic in the builder!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+10
@Workiva/release-management-p
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
Motivation
Error boundaries show a minified version of a class component's name when an error is caught in production. This PR adds a fix, making it so the component's name should be shown in the stack trace of the error boundary.
Changes
displayName
property on class based componentsregisterComponent2
functionRelease Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: