-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FED-580 Add jsifyMapListProp
and unjsifyMapListProp
conversion utils
#795
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
jsifyMapListProp
and unjsifyMapListProp
conversion utilsjsifyMapListProp
and unjsifyMapListProp
conversion utils
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small things, plus the additional test coverage from that other thread, otherwise this looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small copypasta stuff and the cast
discussion/tests above, otherwise LGTM!
Co-authored-by: Greg Littlefield <greg.littlefield@workiva.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+10 pending passing CI
@Workiva/release-management-p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
Motivation
We need prop conversion utils to convert and unconvert
List<JsMap>
using(un)jsifyMapProp
utils for DataGridPro generationChanges
jsifyMapListProp
andunjsifyMapListProp
conversion utilsRelease Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: