Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FED-580 Add jsifyMapListProp and unjsifyMapListProp conversion utils #795

Merged
merged 6 commits into from
Dec 7, 2022

Conversation

sydneyjodon-wk
Copy link
Contributor

Motivation

We need prop conversion utils to convert and unconvert List<JsMap> using (un)jsifyMapProp utils for DataGridPro generation

Changes

  • Add jsifyMapListProp and unjsifyMapListProp conversion utils
  • Add tests

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Frontend Frameworks Design member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@rmconsole7-wk rmconsole7-wk changed the title Add jsifyMapListProp and unjsifyMapListProp conversion utils FED-580 Add jsifyMapListProp and unjsifyMapListProp conversion utils Dec 6, 2022
@greglittlefield-wf greglittlefield-wf self-assigned this Dec 6, 2022
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small things, plus the additional test coverage from that other thread, otherwise this looks good!

Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small copypasta stuff and the cast discussion/tests above, otherwise LGTM!

Co-authored-by: Greg Littlefield <greg.littlefield@workiva.com>
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10 pending passing CI

@sydneyjodon-wk
Copy link
Contributor Author

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole6-wk rmconsole6-wk merged commit ba3e258 into master Dec 7, 2022
@rmconsole6-wk rmconsole6-wk deleted the add-jsifyMapListProp-utils branch December 7, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants