Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FED-675 Stop running plugin build on Dart 3 to fix CI #798

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

greglittlefield-wf
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf commented Jan 18, 2023

Motivation

Changes

  • Stop running CI on Dart 3 since it'll never pass
  • Run main root CI on Dart stable as well
    • I started down this path and then ran into a few more issues, which we can address in a follow-up

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Frontend Frameworks Design member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@greglittlefield-wf greglittlefield-wf changed the title Stop running plugin on Dart 3, run root on stable Stop running plugin on Dart 3 Jan 18, 2023
@greglittlefield-wf greglittlefield-wf force-pushed the greglittlefield-wf-patch-3 branch from 42bb297 to a7310de Compare January 18, 2023 21:57
@greglittlefield-wf greglittlefield-wf changed the title Stop running plugin on Dart 3 Stop running plugin build on Dart 3 to fix CI Jan 18, 2023
@greglittlefield-wf greglittlefield-wf marked this pull request as ready for review January 18, 2023 22:08
@rmconsole3-wf rmconsole3-wf changed the title Stop running plugin build on Dart 3 to fix CI FED-675 Stop running plugin build on Dart 3 to fix CI Jan 18, 2023
Copy link
Contributor

@hunterbreathat-wk hunterbreathat-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@hunterbreathat-wk hunterbreathat-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

CI is passing

@greglittlefield-wf
Copy link
Contributor Author

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole3-wf rmconsole3-wf merged commit 99a77d3 into master Jan 18, 2023
@rmconsole3-wf rmconsole3-wf deleted the greglittlefield-wf-patch-3 branch January 18, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants