Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FED-2136 Deprecate optional value argument in useRef hook & createContext fn #909

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

aaronlademann-wf
Copy link
Contributor

@aaronlademann-wf aaronlademann-wf commented Apr 5, 2024

Motivation

Consumers of useRef/createContext setting an initial / default value should use useRefInit / createContextInit instead to prepare for null safety.

Changes

Formally deprecate the optional initialValue / defaultValue args in the aforementioned hooks.

QA

  • Passing CI

Now that over_react 5.0 has been propagated throughout the wk ecosystem
@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@aaronlademann-wf aaronlademann-wf marked this pull request as ready for review April 5, 2024 15:44
@aaronlademann-wf aaronlademann-wf changed the title FED-2136 Deprecate optional value argument in useRef & createContext hooks FED-2136 Deprecate optional value argument in useRef hook & createContext fn Apr 5, 2024
@aaronlademann-wf
Copy link
Contributor Author

QA +1

  • Passing CI

@Workiva/release-management-pp

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole3-wf rmconsole3-wf merged commit fa553bb into master Apr 5, 2024
7 checks passed
@rmconsole3-wf rmconsole3-wf deleted the FED-2136_deprecate_args branch April 5, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants